Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ux: better ledger rejection error #9242

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 1, 2022

Print a more understandable error message when signing a transaction is being rejected on ledger.

Related Issues

resolves #5335

Proposed Changes

Prints out a more understandable error message.

./lotus send --from=t1ybav9myh3cb6ltslejecasegosgnggcx6ld2nwi t3qcixsxivj5ygpqhi2ima526btslwexuzwl2urlto4wweszdkb4cs6bq65bwcsw7uvfpvmhxbn4norpne6zza 0.01
ERROR: transaction rejected on ledger: publishing message: failed to sign message: [APDU_CODE_COMMAND_NOT_ALLOWED] Command not allowed (no current EF)

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

Print a more understandable error message when a transaction is being rejected on ledger.
@rjan90 rjan90 requested a review from a team as a code owner September 1, 2022 14:45
Fix lint
@arajasek arajasek merged commit c147e31 into master Sep 1, 2022
@arajasek arajasek deleted the fix/ledger-reject-error branch September 1, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ugly error message when rejecting transation on ledger
3 participants