Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly error message when rejecting transation on ledger #5335

Closed
whyrusleeping opened this issue Jan 12, 2021 · 2 comments · Fixed by #9242
Closed

Ugly error message when rejecting transation on ledger #5335

whyrusleeping opened this issue Jan 12, 2021 · 2 comments · Fixed by #9242
Labels
area/ux Area: UX

Comments

@whyrusleeping
Copy link
Member

If i attempt to sign a transaction with my ledger, but then decide to reject when reviewing it on the device, i get a not great error message:

why@sirius ~/c/lotus (master)> ./lotus send --from=f1LEDGER f1MYBANK 0.01

ERROR: failed to sign message: [APDU_CODE_COMMAND_NOT_ALLOWED] Command not allowed (no current EF)
@rjan90
Copy link
Contributor

rjan90 commented May 5, 2022

Reproduced this error message, and it seems like this error messages comes from the Ledger Filecoin app. I have asked in Zondax/ledger-filecoin#108 if it would be possible to change the error message to something more describing.

@rjan90 rjan90 added the area/ux Area: UX label May 5, 2022
@Kubuxu
Copy link
Contributor

Kubuxu commented May 6, 2022

We could also handle it better on our side. IMO the Zondax Ledger API itself doesn't need to provide better error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Area: UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants