Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FVM: always enable tracing for user-triggered executions #9036

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

Closes #8926

Proposed Changes

  • If LOTUS_VM_ENABLE_TRACING is set to 1, the FVM always produces execution traces.
  • If LOTUS_VM_ENABLE_TRACING is not set to 1, the FVM produces execution traces on calls from StateCompute, StateReplay, and StateCall. It does not do so during regular execution.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner July 14, 2022 19:45
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #9036 (474a502) into master (ca713c5) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9036      +/-   ##
==========================================
- Coverage   40.90%   40.87%   -0.04%     
==========================================
  Files         707      707              
  Lines       78746    78746              
==========================================
- Hits        32211    32187      -24     
- Misses      41034    41061      +27     
+ Partials     5501     5498       -3     
Impacted Files Coverage Δ
chain/stmgr/stmgr.go 63.50% <ø> (ø)
chain/stmgr/utils.go 25.58% <0.00%> (-0.20%) ⬇️
chain/vm/runtime.go 49.26% <ø> (ø)
chain/vm/vm.go 58.79% <ø> (ø)
chain/vm/vmi.go 66.66% <ø> (+26.66%) ⬆️
chain/consensus/filcns/compute_state.go 74.41% <100.00%> (+0.14%) ⬆️
chain/stmgr/call.go 70.58% <100.00%> (-2.93%) ⬇️
chain/stmgr/execute.go 91.30% <100.00%> (ø)
chain/vm/fvm.go 29.61% <100.00%> (ø)
chain/consensus/filcns/weight.go 70.58% <0.00%> (-5.89%) ⬇️
... and 32 more

@arajasek arajasek merged commit 7972bd8 into master Jul 15, 2022
@arajasek arajasek deleted the asr/tracing branch July 15, 2022 19:09
@jennijuju
Copy link
Member

whats the thinking behind, still getting all tracing instead of just gas tracing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable detailed exec trace by default for user initiated action
3 participants