Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable detailed exec trace by default for user initiated action #8926

Closed
5 of 15 tasks
jennijuju opened this issue Jun 27, 2022 · 0 comments · Fixed by #9036
Closed
5 of 15 tasks

Enable detailed exec trace by default for user initiated action #8926

jennijuju opened this issue Jun 27, 2022 · 0 comments · Fixed by #9036
Assignees
Labels
kind/enhancement Kind: Enhancement P1 P1: Must be resolved

Comments

@jennijuju
Copy link
Member

Checklist

  • This is not a new feature or an enhancement to the Filecoin protocol. If it is, please open an FIP issue.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated improvement to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Improvement Suggestion

with #8514 , to get full gas tracing and execution trace, the node operator needs to enable * LOTUS_VM_ENABLE_TRACING*, which is a breaking behaviour from legacy user from a getting exeuction trace persepctive.

Suggestion: We should:

  • always generate full execution traces when it's an user iniitated action, i.e, when calling statereplay/statecompute/statecall
  • rename LOTUS_VM_ENABLE_TRACING to LOTUS_VM_ENABLE_GAS_TRACING and only generate gas tracew when this envvar is enabled.
  • During normal sync, generate nothing
@jennijuju jennijuju added need/triage kind/enhancement Kind: Enhancement P2 P2: Should be resolved P1 P1: Must be resolved and removed need/triage P2 P2: Should be resolved labels Jun 27, 2022
@arajasek arajasek self-assigned this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: Enhancement P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants