Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FVM: Support exectraces #8514

Merged
merged 1 commit into from
Apr 19, 2022
Merged

feat: FVM: Support exectraces #8514

merged 1 commit into from
Apr 19, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Apr 19, 2022

Related Issues

Updates to FFI master, FVM 0.7.1.

Allows generation of execution traces from the FVM, using the LOTUS_VM_ENABLE_GAS_TRACING_VERY_SLOW envvar. We should rename this variable assuming it won't break existing setups, ideally making it a runtime flag that we can choose.

The only fields that we are "losing" from the execution traces produced by the Legacy VM are the Duration and GasCharges fields. I'm hoping that neither of these are too critical, but we can (partially) add them later.

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner April 19, 2022 17:45
@arajasek arajasek force-pushed the asr/exec-trace branch 4 times, most recently from e822b38 to 9f3de44 Compare April 19, 2022 18:22
@arajasek
Copy link
Contributor Author

Need to pull this into feat/nv16 as well

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #8514 (36a8d97) into master (1922e76) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8514      +/-   ##
==========================================
- Coverage   40.77%   40.69%   -0.09%     
==========================================
  Files         686      686              
  Lines       75501    75522      +21     
==========================================
- Hits        30787    30732      -55     
- Misses      39403    39467      +64     
- Partials     5311     5323      +12     
Impacted Files Coverage Δ
chain/vm/fvm.go 0.00% <0.00%> (ø)
chain/vm/runtime.go 53.17% <0.00%> (ø)
chain/vm/vm.go 61.63% <0.00%> (-1.07%) ⬇️
chain/stmgr/call.go 65.94% <0.00%> (-6.49%) ⬇️
chain/events/observer.go 73.79% <0.00%> (-6.21%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
chain/sub/incoming.go 59.02% <0.00%> (-2.45%) ⬇️
miner/miner.go 57.04% <0.00%> (-2.30%) ⬇️
extern/sector-storage/sched.go 84.41% <0.00%> (-1.53%) ⬇️
lib/rpcenc/reader.go 70.29% <0.00%> (-1.49%) ⬇️
... and 12 more

@arajasek arajasek merged commit 2410cf3 into master Apr 19, 2022
@arajasek arajasek deleted the asr/exec-trace branch April 19, 2022 22:03
@jennijuju
Copy link
Member

(leaving a comment for future me: we are disabling this by default for security consideration for future user actors, to avoid bad details traces getting accumulated on the node)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants