Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sealing pipeline: Remove adapter code (storage refactors part 2) #8871

Merged
merged 17 commits into from
Jun 17, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jun 16, 2022

Related Issues

Part 2 of #8793

Proposed Changes

Remove redundant adapter boilerplate from the storage/ package. Use the API directly.

Also adds cbor marshalers to TipSetKey which match the now removed TipSetTokens. Confirmed that it's still compatible with existing metadata on my SP setup.

@magik6k magik6k requested a review from a team as a code owner June 16, 2022 15:35
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to be addressed. Everything else looks good :)

storage/pipeline/checks.go Outdated Show resolved Hide resolved
markets/storageadapter/ondealsectorcommitted.go Outdated Show resolved Hide resolved
markets/storageadapter/ondealsectorcommitted_test.go Outdated Show resolved Hide resolved
storage/miner.go Show resolved Hide resolved
@magik6k magik6k merged commit 2c3dbb2 into master Jun 17, 2022
@magik6k magik6k deleted the chore/drop-pipeline-adapters branch June 17, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants