Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sealing code refators #8793

Closed
magik6k opened this issue Jun 2, 2022 · 0 comments
Closed

Sealing code refators #8793

magik6k opened this issue Jun 2, 2022 · 0 comments
Assignees
@magik6k
Labels
area/sealing effort/days Effort: Multiple Days kind/enhancement Kind: Enhancement P3 P3: Might get resolved status/blocked

Comments

@magik6k
Copy link
Contributor

magik6k commented Jun 2, 2022 •
edited
Loading

The sealing code is structured in a very weird way due to historic reasons; We should revisit those decisions, and possibly cleanup some things:

  • Move code from extern/ into directories which make more sense, closer to proving code in storage/
  • Remove adapter code from storage/
  • Get rid of the specs-storage repo, which as far as I can tell only exists to slow down development on sealing code and be annoying.
  • Structure packages in a way which will make future refactors easier

(blocked by nv16 changes landing in master, those refactors would generate a lot of conflicts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magik6k magik6k

Labels
area/sealing effort/days Effort: Multiple Days kind/enhancement Kind: Enhancement P3 P3: Might get resolved status/blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magik6k @jennijuju