Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: storage refactors part 1 #8858

Merged
merged 15 commits into from
Jun 15, 2022
Merged

chore: storage refactors part 1 #8858

merged 15 commits into from
Jun 15, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jun 14, 2022

Related Issues

Part 1 of #8793

Proposed Changes

  • Move things in storage/ into clean sub-packages
  • Move non-extern things from extern/ to packages in storage/

For the next PR (didn't want to put logic changes in this PR to avoid mixing them with a big high-noise diff):

  • Remove storage/adapter_*.go
  • Drop dependency on specs-storage
  • Add new architecture Readme to storage/

Main moves are:

  • storage/wdpost_*.go -> storage/wdpost/ - making space for other storage related packages here
  • extern/sector-storage -> storage/sealer - don't pretend like this will live in a separate repo; should be much easier to find
  • extern/sector-storage/stores -> storage/paths - The stores package mostly deals with paths with sectors, seems like a much more logical name.
  • extern/storage-sealing -> storage/pipeline - This is the sealing pipeline; didn't want to name it sealer/sealing for the obvious reason that it sounds a bit like sealer which is already in use above.

There may be some more PRs moving things around, but this should be the biggest one, addressing the most annoying/overdue things

@magik6k magik6k force-pushed the chore/storage-refactors branch from fc96506 to dff1bf2 Compare June 14, 2022 17:27
@magik6k magik6k force-pushed the chore/storage-refactors branch from 34e2a5d to 82857e6 Compare June 14, 2022 18:13
@magik6k magik6k force-pushed the chore/storage-refactors branch from dc46626 to a581d73 Compare June 14, 2022 18:36
@magik6k magik6k changed the title [wip] chore: storage refactors chore: storage refactors part 1 Jun 14, 2022
@magik6k magik6k marked this pull request as ready for review June 14, 2022 19:19
@magik6k magik6k requested a review from a team as a code owner June 14, 2022 19:19
@magik6k magik6k force-pushed the chore/storage-refactors branch from bf192d0 to 5ba12c4 Compare June 14, 2022 19:30
@magik6k magik6k force-pushed the chore/storage-refactors branch from 5ba12c4 to 39cede9 Compare June 14, 2022 19:38
Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter needs to be appeased.

Github is also complaining about some unsanitized logs, but it looks like most of these are coming from sources with admin perms anyway?

api/api_storage.go Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the chore/storage-refactors branch from fcaf76e to a2e9167 Compare June 15, 2022 12:13
@magik6k magik6k force-pushed the chore/storage-refactors branch from a2e9167 to 6d770f6 Compare June 15, 2022 14:51
@geoff-vball geoff-vball merged commit b706efc into master Jun 15, 2022
@geoff-vball geoff-vball deleted the chore/storage-refactors branch June 15, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants