-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: storage refactors part 1 #8858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 14, 2022 17:27
fc96506
to
dff1bf2
Compare
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 14, 2022 18:13
34e2a5d
to
82857e6
Compare
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 14, 2022 18:36
dc46626
to
a581d73
Compare
magik6k
changed the title
[wip] chore: storage refactors
chore: storage refactors part 1
Jun 14, 2022
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 14, 2022 19:30
bf192d0
to
5ba12c4
Compare
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 14, 2022 19:38
5ba12c4
to
39cede9
Compare
geoff-vball
reviewed
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter needs to be appeased.
Github is also complaining about some unsanitized logs, but it looks like most of these are coming from sources with admin perms anyway?
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 15, 2022 12:13
fcaf76e
to
a2e9167
Compare
geoff-vball
reviewed
Jun 15, 2022
magik6k
force-pushed
the
chore/storage-refactors
branch
from
June 15, 2022 14:51
a2e9167
to
6d770f6
Compare
geoff-vball
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Part 1 of #8793
Proposed Changes
storage/
into clean sub-packagesextern/
to packages instorage/
For the next PR (didn't want to put logic changes in this PR to avoid mixing them with a big high-noise diff):
storage/adapter_*.go
storage/
Main moves are:
storage/wdpost_*.go
->storage/wdpost/
- making space for other storage related packages hereextern/sector-storage
->storage/sealer
- don't pretend like this will live in a separate repo; should be much easier to findextern/sector-storage/stores
->storage/paths
- Thestores
package mostly deals with paths with sectors, seems like a much more logical name.extern/storage-sealing
->storage/pipeline
- This is the sealing pipeline; didn't want to name it sealer/sealing for the obvious reason that it sounds a bit likesealer
which is already in use above.There may be some more PRs moving things around, but this should be the biggest one, addressing the most annoying/overdue things