Merge nv16 changes into master #8810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses the global MAX_LEN exported by fvm_shared. - Formats errors with debug, for additional information.
chore: deps: update filecoin-ffi
…ad-bundle Cleanup LoadBundle
chore: vm: Rename tracing envvar to LOTUS_VM_ENABLE_TRACING
…id-bundle-cli Fix: cli: clean up manifest-cid-from-car
chore: deps: update to go-libp2p v0.19.4
chore: build: merge v1.15.3 into v1.16.0
fix: build: use the genesis network version when creating a network
vyzo
approved these changes
Jun 8, 2022
magik6k
reviewed
Jun 8, 2022
| inv.Register(actors.Version5, vm.ActorsVersionPredicate(actors.Version5), exported5.BuiltinActors()...) | ||
| inv.Register(actors.Version6, vm.ActorsVersionPredicate(actors.Version6), exported6.BuiltinActors()...) | ||
| inv.Register(actors.Version7, vm.ActorsVersionPredicate(actors.Version7), exported7.BuiltinActors()...) | ||
| inv.Register(actors.Version8, vm.ActorsVersionPredicate(actors.Version8), exported8.BuiltinActors()...) |
There was a problem hiding this comment.
Do we want v8 go actors in legacy invoker?
There was a problem hiding this comment.
We do need this, yes. We ask to register the wrong BuiltinActors() (from v8 go-actors), which we then transform to use the right CIDs and setup the Methods info correctly
There was a problem hiding this comment.
In that case, do we maybe want to keep the inline-gen here? (fine without it, just not sure why it got dropped)
There was a problem hiding this comment.
Lolol, it got dropped because I thought it was gonna go, and then had to re-add it :P
I'll bring it back.
| ret := res.MsgRct.GasUsed | ||
|
|
||
| transitionalMulti := 1.0 | ||
| // Overestimate gas around the upgrade |
There was a problem hiding this comment.
Can we create an issue to remove (or make more reusable/cleaner/self contained) this after the upgrade epoch?
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
c235316 to
82e4391
Compare
94007f8 to
b211c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the changes developed in the feat/nv16 branch into master.