Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deps: macos build deps #8581

Merged
merged 2 commits into from
May 3, 2022
Merged

ci: deps: macos build deps #8581

merged 2 commits into from
May 3, 2022

Conversation

travisperson
Copy link
Contributor

@travisperson travisperson commented May 2, 2022

Related Issues

#8580

Proposed Changes

Remove install-deps step from macos builds

Additional Info

I also removed the filtering from build-macos and build-all so that these tasks run for all PRs to avoid build breaking only being detected during a release.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@travisperson travisperson changed the title Fix/macos build deps ci: deps: macos build deps May 2, 2022
@travisperson travisperson force-pushed the fix/macos-build-deps branch from a76ebdf to 620028c Compare May 2, 2022 20:29
@travisperson travisperson force-pushed the fix/macos-build-deps branch from 620028c to 415b506 Compare May 2, 2022 20:37
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #8581 (415b506) into master (88f8c7d) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8581      +/-   ##
==========================================
- Coverage   40.86%   40.75%   -0.11%     
==========================================
  Files         686      686              
  Lines       75710    75710              
==========================================
- Hits        30939    30858      -81     
- Misses      39445    39502      +57     
- Partials     5326     5350      +24     
Impacted Files Coverage Δ
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/events/observer.go 73.79% <0.00%> (-7.59%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-6.35%) ⬇️
miner/miner.go 55.73% <0.00%> (-4.92%) ⬇️
chain/stmgr/call.go 65.94% <0.00%> (-3.25%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-2.57%) ⬇️
chain/sync_manager.go 74.22% <0.00%> (-2.49%) ⬇️
chain/sub/incoming.go 59.02% <0.00%> (-2.45%) ⬇️
extern/storage-sealing/currentdealinfo.go 70.17% <0.00%> (-1.76%) ⬇️
... and 8 more

@jennijuju jennijuju changed the base branch from master to release/v1.15.2 May 2, 2022 21:20
@jennijuju jennijuju changed the base branch from release/v1.15.2 to master May 2, 2022 21:20
@travisperson travisperson marked this pull request as ready for review May 2, 2022 23:35
@travisperson travisperson requested a review from a team as a code owner May 2, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants