Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to bundle release assets #8594

Closed
7 of 18 tasks
travisperson opened this issue May 4, 2022 · 1 comment
Closed
7 of 18 tasks

Failure to bundle release assets #8594

travisperson opened this issue May 4, 2022 · 1 comment
Labels
kind/bug Kind: Bug

Comments

@travisperson
Copy link
Contributor

travisperson commented May 4, 2022

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

not lotus, but ci but kind of v1.15.2-rc3?

Describe the Bug

Lotus releases fail to find the built binaries when bundling

https://app.circleci.com/pipelines/github/filecoin-project/lotus/20910/workflows/d1b3d635-6625-49cc-b9f5-48e25085de45/jobs/453365/parallel-runs/0/steps/0-107

It looks like we are no longer running the build-all / build-macos on tagged releases. This was broken in #8581.

Screen Shot 2022-05-04 at 10 37 56 AM

CircleCI does not run on tags by default

CircleCI does not run workflows for tags unless you explicitly specify tag filters. Additionally, if a job requires any other jobs (directly or indirectly), you must use regular expressions to specify tag filters for those jobs. Both lightweight and annotated tags are supported.
https://circleci.com/docs/2.0/workflows/#executing-workflows-for-a-git-tag

When attempting to make sure that build-all and build-macos ran on every PR to ensure build breaking PRs were caught before releases, this also removed the running of the jobs on tags.

We need to add back the tag part that was removed in #8581

tags:
  only:
    - /^v\d+\.\d+\.\d+(-rc\d+)?$/

Logging Information

+ for ARCH in "${ARCHS[@]}"
+ mkdir -p darwin/lotus
+ pushd darwin
~/project/bundle/darwin ~/project/bundle ~/project
+ for BINARY in "${BINARIES[@]}"
+ cp ../../darwin/lotus lotus/
cp: cannot stat '../../darwin/lotus': No such file or directory
+ kill -9 3507

Exited with code exit status 1
CircleCI received exit code 1

Repo Steps

Make a lotus release

@travisperson
Copy link
Contributor Author

travisperson commented May 4, 2022

@jennijuju we do not have assets for v1.15.2-rc3 due to this issue. I don't think it's worth going through the effort to create them at the moment. We should ensure this issue is resolve prior to the next rc or actual release though.

I think this issue should be added to the v1.15.2 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

No branches or pull requests

1 participant