Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FVM: add finality check for consensus faults #8452

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Apr 7, 2022

Related Issues

This caused a state mismatch on some FVM nodes on mainnet when executing message bafy2bzacedvprfrgzze2fvqutxl5za3jtwaqzgq7nwzlewf6e3q7pk7fuh3e6. While the fix is easy, we should try to understand why only some nodes lost consensus -- my guess is that those nodes that stayed in consensus were using snaphots that did not have the state root in question, and so failed with a different error, but the same gas usage.

Proposed Changes

Add the missing fix.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #8452 (d1c0b8b) into master (20698a7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8452      +/-   ##
==========================================
- Coverage   40.66%   40.62%   -0.04%     
==========================================
  Files         686      686              
  Lines       75439    75441       +2     
==========================================
- Hits        30680    30651      -29     
- Misses      39458    39479      +21     
- Partials     5301     5311      +10     
Impacted Files Coverage Δ
chain/vm/fvm.go 0.00% <0.00%> (ø)
chain/events/state/fastapi.go 75.00% <0.00%> (-25.00%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-2.57%) ⬇️
chain/sub/incoming.go 45.25% <0.00%> (-2.45%) ⬇️
chain/events/events_called.go 88.29% <0.00%> (-1.96%) ⬇️
miner/miner.go 55.73% <0.00%> (-1.64%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
chain/messagepool/selection.go 83.07% <0.00%> (-0.77%) ⬇️
extern/storage-sealing/fsm.go 60.33% <0.00%> (-0.67%) ⬇️
... and 12 more

@magik6k magik6k merged commit e2f4c70 into master Apr 7, 2022
@magik6k magik6k deleted the asr/fvm-consensus-fault branch April 7, 2022 17:07
@arajasek arajasek mentioned this pull request Apr 7, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants