Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multisig: lotus-sheed miner-multisig change-worker command. #8281

Merged
merged 3 commits into from
Mar 17, 2022
Merged

feat: multisig: lotus-sheed miner-multisig change-worker command. #8281

merged 3 commits into from
Mar 17, 2022

Conversation

spark8899
Copy link
Contributor

@spark8899 spark8899 commented Mar 10, 2022

Related Issues

lotus-shed miner-multisig add change-worker command

Proposed Changes

Added two subcommands, propose-change-worker and Confirm-change-worker.

Additional Info

lotus-shed miner-multisig --from --miner --multisig propose-change-worker
lotus msig approve --from

lotus-shed miner-multisig --from --miner --multisig Confirm-change-worker
lotus msig approve --from

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@spark8899 spark8899 requested a review from a team as a code owner March 10, 2022 06:30
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Msig worker address won't really work (it's impossible to sign blocks with msig worker address), but I guess utils to undo setting an msig worker are nice to have.

cmd/lotus-shed/miner-multisig.go Outdated Show resolved Hide resolved
cmd/lotus-shed/miner-multisig.go Outdated Show resolved Hide resolved
cmd/lotus-shed/miner-multisig.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #8281 (2cf0e4c) into master (c192637) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8281      +/-   ##
==========================================
- Coverage   40.51%   40.42%   -0.10%     
==========================================
  Files         675      675              
  Lines       73527    73694     +167     
==========================================
  Hits        29788    29788              
- Misses      38515    38676     +161     
- Partials     5224     5230       +6     
Impacted Files Coverage Δ
cmd/lotus-shed/miner-multisig.go 0.00% <0.00%> (ø)
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-1.65%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
extern/sector-storage/stores/local.go 59.16% <0.00%> (-0.84%) ⬇️
miner/miner.go 55.73% <0.00%> (-0.66%) ⬇️
chain/sync_manager.go 73.91% <0.00%> (-0.63%) ⬇️
itests/kit/blockminer.go 69.61% <0.00%> (-0.56%) ⬇️
... and 8 more

@magik6k magik6k merged commit e0481bb into filecoin-project:master Mar 17, 2022
@silvianetobessa
Copy link

Hello @spark8899 !

This contribution to the Filecoin codebase was voted as impactful during Q1 and is eligible for a FIL prize as part of a Protocol Labs experiment to reward open source contributions from the community (see full details here).

Please reach out to us through commons@protocol.ai to receive the instructions on how to claim your reward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants