Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: add flag usage #8189

Merged
merged 2 commits into from
Feb 26, 2022
Merged

fix: sealing: add flag usage #8189

merged 2 commits into from
Feb 26, 2022

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Feb 25, 2022

Related Issues

fixes #8106 (comment)

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner February 25, 2022 15:29
@jennijuju jennijuju marked this pull request as draft February 25, 2022 15:31
@jennijuju jennijuju changed the base branch from release/v1.14.2 to release/v1.14.3 February 25, 2022 15:43
@jennijuju jennijuju marked this pull request as ready for review February 25, 2022 15:43
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #8189 (433f9f8) into release/v1.14.3 (a65386b) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.14.3    #8189      +/-   ##
===================================================
- Coverage            39.40%   39.27%   -0.13%     
===================================================
  Files                  657      657              
  Lines                71070    71070              
===================================================
- Hits                 28006    27914      -92     
- Misses               38233    38296      +63     
- Partials              4831     4860      +29     
Impacted Files Coverage Δ
cmd/lotus-miner/sectors.go 13.97% <ø> (ø)
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
miner/miner.go 52.13% <0.00%> (-9.51%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-8.21%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/stmgr/tracers.go 84.21% <0.00%> (-5.27%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
chain/vm/mkactor.go 48.48% <0.00%> (-3.04%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65386b...433f9f8. Read the comment docs.

@jennijuju jennijuju merged commit 6347daf into release/v1.14.3 Feb 26, 2022
@jennijuju jennijuju deleted the jen/reallydoitflag branch February 26, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants