Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort-upgrade should have --really-do-it flag #8106

Closed
8 of 18 tasks
ZenGround0 opened this issue Feb 16, 2022 · 2 comments
Closed
8 of 18 tasks

abort-upgrade should have --really-do-it flag #8106

ZenGround0 opened this issue Feb 16, 2022 · 2 comments
Labels
kind/bug Kind: Bug P2 P2: Should be resolved SnapDeals
Milestone

Comments

@ZenGround0
Copy link
Contributor

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

Daemon:  1.15.0-rc1+2k+git.439b42426.dirty+api1.3.0
Local: lotus-miner version 1.15.0-rc1+2k+git.439b42426.dirty

Describe the Bug

We should have a --really-do-it flag added onto abort-upgrade since it is potentially dangerous

Logging Information

nada

Repo Steps

  1. ./lotus-miner sectors abort-upgrade will run without yelling at you first
@Reiers Reiers added SnapDeals P2 P2: Should be resolved and removed need/triage labels Feb 16, 2022
@Reiers Reiers added this to the v1.15.0 milestone Feb 16, 2022
@Reiers
Copy link

Reiers commented Feb 25, 2022

Im not able to abort the upgrade at all now.

reiers@reiers-PL-tests:~$ lotus-miner sectors list
ID  State               OnChain  Active  Expiration                    Deals  
0   SnapDealsWaitDeals  YES      YES     2265143 (in 1 year 24 weeks)  CC     
1   Proving             YES      YES     2265795 (in 1 year 24 weeks)  CC     
2   Proving             YES      YES     2265817 (in 1 year 24 weeks)  CC     
3   Proving             YES      YES     2266352 (in 1 year 24 weeks)  CC     
4   PreCommit1          NO       NO      n/a                           CC     
5   PreCommit1          NO       NO      n/a                           CC 
reiers@reiers-PL-tests:~$ lotus-miner sectors abort-upgrade 0
ERROR: --really-do-it must be specified for this action to have an effect; you have been warned

lotus-miner sectors abort-upgrade --really-do-it 0

Incorrect Usage: bad flag syntax: --really-do-it
ERROR: bad flag syntax: ---really-do-it
lotus-miner sectors abort-upgrade 0 --really-do-it
ERROR: must pass sector number
reiers@reiers-PL-tests:~$ lotus-miner sectors update-state AbortedUpgrade --really-do-it 0
ERROR: this is a command for advanced users, only use it if you are sure of what you are doing

reiers@reiers-PL-tests:~$ lotus-miner sectors update-state --really-do-it AbortedUpgrade 0
ERROR: could not parse sector number: strconv.ParseUint: parsing "AbortedUpgrade": invalid syntax

reiers@reiers-PL-tests:~$ lotus-miner sectors update-state --really-do-it 0 AbortedUpgrade
 "AbortedUpgrade" is not a valid state

Lotus version:

Daemon:  1.14.2+calibnet+git.a65386b49+api1.5.0
Local: lotus version 1.14.2+calibnet+git.a65386b49

@Reiers
Copy link

Reiers commented Feb 28, 2022

@Reiers Reiers closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug P2 P2: Should be resolved SnapDeals
Projects
None yet
Development

No branches or pull requests

2 participants