Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build: v1.14.0 -> master #8053

Merged
merged 122 commits into from
Feb 10, 2022
Merged

chore: build: v1.14.0 -> master #8053

merged 122 commits into from
Feb 10, 2022

Conversation

jennijuju
Copy link
Member

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

jennijuju and others added 30 commits January 11, 2022 17:01
feat: param: add temp snap params
… have to yourself fails with an error (fixing issue 7596)

PR #7637, also adds tests to make sure behavior is correct across versions.
This is the very first iteration of the lotus PR template. The goal of adding PR template is to standardize PR requests and encourage contributors to:
- come up with good PR descriptions to give code reviewers a clear overview of what's in the PR 
- have a clear PR title as lotus generates a change log based on it
- check that tests and documentation for the codes that changed are icnluded 

The PR type follows the https://www.conventionalcommits.org/en/v1.0.0-beta.2/.  The [contribution guideline](https://github.com/filecoin-project/lotus#contribute) should be updated with how to create a pr after the template is accepted.
- Unsealing replica update with sector key works and tested
- Sector key generation added and tested
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
issue number in PR title is not that useful because reader cannot click it and need to mention the issue in the body for auto close either way.
- FSM handles the actual cc upgrade process including error states
- PoSting (winning and window) works over upgraded and upgrading sectors
- Integration test and changes to itest framework to reduce flakes
- Update CLI to handle new upgrade
- Update dependencies
@jennijuju jennijuju requested a review from a team as a code owner February 9, 2022 08:13
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #8053 (1d67b7f) into master (e7038d2) will decrease coverage by 0.10%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8053      +/-   ##
==========================================
- Coverage   39.18%   39.08%   -0.11%     
==========================================
  Files         662      662              
  Lines       72139    72160      +21     
==========================================
- Hits        28271    28201      -70     
- Misses      38972    39040      +68     
- Partials     4896     4919      +23     
Impacted Files Coverage Δ
api/api_storage.go 0.00% <ø> (ø)
cmd/lotus-miner/sectors.go 13.97% <0.00%> (-0.16%) ⬇️
extern/storage-sealing/fsm.go 57.49% <ø> (ø)
extern/storage-sealing/input.go 53.23% <0.00%> (-0.67%) ⬇️
extern/storage-sealing/states_failed.go 0.00% <0.00%> (ø)
extern/storage-sealing/states_replica_update.go 38.79% <0.00%> (+0.62%) ⬆️
extern/storage-sealing/states_sealing.go 38.04% <0.00%> (ø)
node/impl/storminer.go 22.40% <0.00%> (-0.41%) ⬇️
storage/miner_sealing.go 85.71% <0.00%> (-1.93%) ⬇️
extern/storage-sealing/checks.go 31.37% <37.50%> (+0.76%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7038d2...1d67b7f. Read the comment docs.

go.mod Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching things I missed! One fix needed!

testplans/docker-images/proof-parameters.json Show resolved Hide resolved
@magik6k magik6k merged commit e435b42 into master Feb 10, 2022
@magik6k magik6k deleted the jen/v15 branch February 10, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants