Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eth: rename yParity to v in transaction return values #10264

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: eth: rename yParity to v in transaction return values #10264

merged 1 commit into from
Feb 13, 2023

Conversation

Stebalien
Copy link
Member

Related Issues

fixes filecoin-project/ref-fvm#1662

Proposed Changes

The openethereum docs say it should be yParity, but Geth uses v and tools rely on v so we should use v. I've taken the liberty of fixing the conformance tests at the same time.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien
fix: eth: rename yParity to v in transaction return values
0a79959 
The openethereum docs say it should be `yParity`, but Geth uses `v` and
tools rely on `v` so we should use `v`. I've taken the liberty of fixing
the conformance tests at the same time.

fixes filecoin-project/ref-fvm#1662
@Stebalien Stebalien requested a review from a team as a code owner February 13, 2023 23:04
@Stebalien Stebalien mentioned this pull request Feb 13, 2023
Closed
@Stebalien Stebalien requested a review from raulk February 13, 2023 23:06
arajasek
arajasek approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I didn't independently confirm that Geth uses v and tools rely on v so we should use v

raulk
raulk approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-checked and confirmed to be correct.

@raulk raulk merged commit a16c540 into release/v1.20.0 Feb 13, 2023
@raulk raulk deleted the steb/lies-damn-lies branch February 13, 2023 23:29
@simlecode simlecode mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @raulk @arajasek