fix: eth: rename yParity to v in transaction return values (#10264)

fixes filecoin-project/ref-fvm#1662
filecoin-project · Feb 13, 2023 · a16c540 · a16c540
1 parent f427c2b
commit a16c540
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 34 deletions.
diff --git a/build/openrpc/full.json.gz b/build/openrpc/full.json.gz
diff --git a/build/openrpc/gateway.json.gz b/build/openrpc/gateway.json.gz
diff --git a/chain/types/ethtypes/eth_transactions.go b/chain/types/ethtypes/eth_transactions.go
@@ -39,7 +39,7 @@ type EthTx struct {
 	MaxFeePerGas         EthBigInt   `json:"maxFeePerGas"`
 	MaxPriorityFeePerGas EthBigInt   `json:"maxPriorityFeePerGas"`
 	AccessList           []EthHash   `json:"accessList"`
-	V                    EthBigInt   `json:"yParity"`
+	V                    EthBigInt   `json:"v"`
 	R                    EthBigInt   `json:"r"`
 	S                    EthBigInt   `json:"s"`
 }

diff --git a/documentation/en/api-v1-unstable-methods.md b/documentation/en/api-v1-unstable-methods.md
@@ -2643,7 +2643,7 @@ Response:
   "accessList": [
     "0x37690cfec6c1bf4c3b9288c7a5d783e98731e90b0a4c177c2a374c7a9427355e"
   ],
-  "yParity": "0x0",
+  "v": "0x0",
   "r": "0x0",
   "s": "0x0"
 }
@@ -2682,7 +2682,7 @@ Response:
   "accessList": [
     "0x37690cfec6c1bf4c3b9288c7a5d783e98731e90b0a4c177c2a374c7a9427355e"
   ],
-  "yParity": "0x0",
+  "v": "0x0",
   "r": "0x0",
   "s": "0x0"
 }
@@ -2720,7 +2720,7 @@ Response:
   "accessList": [
     "0x37690cfec6c1bf4c3b9288c7a5d783e98731e90b0a4c177c2a374c7a9427355e"
   ],
-  "yParity": "0x0",
+  "v": "0x0",
   "r": "0x0",
   "s": "0x0"
 }

diff --git a/itests/specs/eth_openrpc.json b/itests/specs/eth_openrpc.json
@@ -178,7 +178,7 @@
 													"s",
 													"type",
 													"value",
-													"yParity"
+													"v"
 												],
 												"properties": {
 													"type": {
@@ -253,8 +253,8 @@
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "Chain ID that this transaction is valid on."
 													},
-													"yParity": {
-														"title": "yParity",
+													"v": {
+														"title": "v",
 														"type": "string",
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -285,7 +285,7 @@
 													"s",
 													"type",
 													"value",
-													"yParity"
+													"v"
 												],
 												"properties": {
 													"type": {
@@ -354,8 +354,8 @@
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "Chain ID that this transaction is valid on."
 													},
-													"yParity": {
-														"title": "yParity",
+													"v": {
+														"title": "v",
 														"type": "string",
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -649,7 +649,7 @@
 													"s",
 													"type",
 													"value",
-													"yParity"
+													"v"
 												],
 												"properties": {
 													"type": {
@@ -724,8 +724,8 @@
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "Chain ID that this transaction is valid on."
 													},
-													"yParity": {
-														"title": "yParity",
+													"v": {
+														"title": "v",
 														"type": "string",
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -756,7 +756,7 @@
 													"s",
 													"type",
 													"value",
-													"yParity"
+													"v"
 												],
 												"properties": {
 													"type": {
@@ -825,8 +825,8 @@
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "Chain ID that this transaction is valid on."
 													},
-													"yParity": {
-														"title": "yParity",
+													"v": {
+														"title": "v",
 														"type": "string",
 														"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 														"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -3009,7 +3009,7 @@
 								"s",
 								"type",
 								"value",
-								"yParity"
+								"v"
 							],
 							"properties": {
 								"type": {
@@ -3084,8 +3084,8 @@
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "Chain ID that this transaction is valid on."
 								},
-								"yParity": {
-									"title": "yParity",
+								"v": {
+									"title": "v",
 									"type": "string",
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -3116,7 +3116,7 @@
 								"s",
 								"type",
 								"value",
-								"yParity"
+								"v"
 							],
 							"properties": {
 								"type": {
@@ -3185,8 +3185,8 @@
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "Chain ID that this transaction is valid on."
 								},
-								"yParity": {
-									"title": "yParity",
+								"v": {
+									"title": "v",
 									"type": "string",
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -3359,7 +3359,7 @@
 								"s",
 								"type",
 								"value",
-								"yParity"
+								"v"
 							],
 							"properties": {
 								"type": {
@@ -3434,8 +3434,8 @@
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "Chain ID that this transaction is valid on."
 								},
-								"yParity": {
-									"title": "yParity",
+								"v": {
+									"title": "v",
 									"type": "string",
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -3466,7 +3466,7 @@
 								"s",
 								"type",
 								"value",
-								"yParity"
+								"v"
 							],
 							"properties": {
 								"type": {
@@ -3535,8 +3535,8 @@
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "Chain ID that this transaction is valid on."
 								},
-								"yParity": {
-									"title": "yParity",
+								"v": {
+									"title": "v",
 									"type": "string",
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -3726,7 +3726,7 @@
 								"s",
 								"type",
 								"value",
-								"yParity"
+								"v"
 							],
 							"properties": {
 								"type": {
@@ -3801,8 +3801,8 @@
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "Chain ID that this transaction is valid on."
 								},
-								"yParity": {
-									"title": "yParity",
+								"v": {
+									"title": "v",
 									"type": "string",
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
@@ -3833,7 +3833,7 @@
 								"s",
 								"type",
 								"value",
-								"yParity"
+								"v"
 							],
 							"properties": {
 								"type": {
@@ -3902,8 +3902,8 @@
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "Chain ID that this transaction is valid on."
 								},
-								"yParity": {
-									"title": "yParity",
+								"v": {
+									"title": "v",
 									"type": "string",
 									"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
 									"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."