Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to the improved error handling in proofs #450

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

cryptonemo
Copy link
Contributor

feat: some shell logic re-factoring

@Stebalien Stebalien marked this pull request as draft April 9, 2024 17:34
@Stebalien
Copy link
Member

(converting to draft till we depend on released crates)

@cryptonemo
Copy link
Contributor Author

@magik6k If you have a way to test those kinds of failures you were seeing, this is the branch to test. It's all draft at this point due to releases being required first as @Stebalien pointed out above.

@magik6k
Copy link
Contributor

magik6k commented Apr 10, 2024

I'll try to get this tested tomorrow, just got a sector in this state again

@magik6k
Copy link
Contributor

magik6k commented Apr 10, 2024

Much better now, nothing panics and the call is just returning error: failed to compute seal proof: failed to generate vanilla proof: Invalid encoding proof generated at layer 1, challenge_index 2 as expected.

@cryptonemo
Copy link
Contributor Author

Copy link
Contributor

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CircleCI config we use 1.67 for rustfmt. I don't expect that it makes much difference, but i think it would make sense to keep it in sync with the version we use in the rust-toolchain.toml.

@cryptonemo cryptonemo force-pushed the improved-error-handling branch from 98638f2 to 80ff911 Compare April 25, 2024 19:36
@cryptonemo
Copy link
Contributor Author

@magik6k @Stebalien This is pointing to a real proofs release now and is good to go on our side. Edit or merge at will.

@magik6k magik6k merged commit ed08caa into master Apr 29, 2024
9 checks passed
@cryptonemo cryptonemo deleted the improved-error-handling branch April 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants