-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to the improved error handling in proofs #450
Conversation
(converting to draft till we depend on released crates) |
@magik6k If you have a way to test those kinds of failures you were seeing, this is the branch to test. It's all draft at this point due to releases being required first as @Stebalien pointed out above. |
I'll try to get this tested tomorrow, just got a sector in this state again |
Much better now, nothing panics and the call is just returning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the CircleCI config we use 1.67 for rustfmt. I don't expect that it makes much difference, but i think it would make sense to keep it in sync with the version we use in the rust-toolchain.toml
.
e1e2294
to
98638f2
Compare
feat: some shell logic re-factoring
98638f2
to
80ff911
Compare
@magik6k @Stebalien This is pointing to a real proofs release now and is good to go on our side. Edit or merge at will. |
feat: some shell logic re-factoring