style: clippy

filecoin-project · Apr 9, 2024 · e1e2294 · e1e2294
1 parent 95f9a76
commit e1e2294
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 16 deletions.
diff --git a/rust/src/bls/api.rs b/rust/src/bls/api.rs
@@ -296,7 +296,7 @@ mod tests {
 
         assert!(verified);
 
-        let message_sizes = vec![message.len()];
+        let message_sizes = [message.len()];
         let flattened_messages = message;
 
         let verified = hash_verify(
@@ -319,7 +319,7 @@ mod tests {
         assert!(!not_verified);
 
         // garbage verification
-        let different_digest = vec![0, 1, 2, 3, 4];
+        let different_digest = [0, 1, 2, 3, 4];
         let not_verified = verify(
             signature[..].into(),
             different_digest[..].into(),

diff --git a/rust/src/fvm/engine.rs b/rust/src/fvm/engine.rs
@@ -73,9 +73,9 @@ impl TryFrom<u32> for EngineVersion {
     fn try_from(value: u32) -> Result<Self, Self::Error> {
         match value {
             16 | 17 => Ok(EngineVersion::V1),
-            18 | 19 | 20 => Ok(EngineVersion::V2),
+            18..=20 => Ok(EngineVersion::V2),
             21 | 22 => Ok(EngineVersion::V3),
-            _ => return Err(anyhow!("network version not supported")),
+            _ => Err(anyhow!("network version not supported")),
         }
     }
 }

diff --git a/rust/src/fvm/mod.rs b/rust/src/fvm/mod.rs
@@ -4,6 +4,7 @@ mod externs;
 
 pub mod engine;
 pub mod machine;
+#[allow(clippy::incorrect_clone_impl_on_copy_type)]
 pub mod types;
 
 pub use cgo::FvmError;
diff --git a/rust/src/proofs/api.rs b/rust/src/proofs/api.rs
@@ -1565,7 +1565,7 @@ pub mod tests {
 
         // write the second
         {
-            let existing = vec![127u64];
+            let existing = [127u64];
 
             let resp = unsafe {
                 write_with_alignment(registered_proof, src_fd_b, 508, dst_fd, existing[..].into())
@@ -1670,7 +1670,7 @@ pub mod tests {
     #[test]
     #[allow(clippy::cognitive_complexity)]
     fn test_sealing_versions() -> Result<()> {
-        let versions = vec![
+        let versions = [
             RegisteredSealProof::StackedDrg2KiBV1,
             RegisteredSealProof::StackedDrg2KiBV1_1,
             RegisteredSealProof::StackedDrg2KiBV1_1_Feat_SyntheticPoRep,
@@ -1745,7 +1745,7 @@ pub mod tests {
                 panic!("write_without_alignment failed: {:?}", msg);
             }
 
-            let existing_piece_sizes = vec![127];
+            let existing_piece_sizes = [127];
 
             let resp_a2 = unsafe {
                 write_with_alignment(
@@ -1762,7 +1762,7 @@ pub mod tests {
                 panic!("write_with_alignment failed: {:?}", msg);
             }
 
-            let pieces = vec![
+            let pieces = [
                 PublicPieceInfo {
                     num_bytes: 127,
                     comm_p: resp_a1.comm_p,
@@ -1987,7 +1987,7 @@ pub mod tests {
                 panic!("write_without_alignment failed: {:?}", msg);
             }
 
-            let existing_piece_sizes = vec![127];
+            let existing_piece_sizes = [127];
 
             let resp_new_a2 = unsafe {
                 write_with_alignment(
@@ -2299,7 +2299,7 @@ pub mod tests {
 
             // generate a PoSt
 
-            let sectors = vec![sector_id];
+            let sectors = [sector_id];
             let resp_f = generate_winning_post_sector_challenge(
                 registered_proof_winning_post,
                 &randomness,
@@ -2553,7 +2553,7 @@ pub mod tests {
             //
             //////////////////////////////////////////////
 
-            let sectors = vec![sector_id, sector_id2];
+            let sectors = [sector_id, sector_id2];
             let private_replicas = vec![
                 PrivateReplicaInfo {
                     registered_proof: registered_proof_window_post,
@@ -2861,7 +2861,7 @@ pub mod tests {
                 panic!("write_without_alignment failed: {:?}", msg);
             }
 
-            let existing_piece_sizes = vec![127];
+            let existing_piece_sizes = [127];
 
             let resp_a2 = unsafe {
                 write_with_alignment(
@@ -3050,7 +3050,7 @@ pub mod tests {
                 panic!("write_without_alignment failed: {:?}", msg);
             }
 
-            let existing_piece_sizes = vec![127];
+            let existing_piece_sizes = [127];
 
             let resp_a2 = unsafe {
                 write_with_alignment(
@@ -3189,10 +3189,10 @@ pub mod tests {
 
             assert!(**resp_d2, "proof was not valid");
 
-            let seal_commit_responses = vec![resp_c2.value.clone(), resp_c22.value.clone()];
+            let seal_commit_responses = [resp_c2.value.clone(), resp_c22.value.clone()];
 
-            let comm_rs = vec![resp_b2.comm_r, resp_b2.comm_r];
-            let seeds = vec![seed, seed];
+            let comm_rs = [resp_b2.comm_r, resp_b2.comm_r];
+            let seeds = [seed, seed];
             let resp_aggregate_proof = aggregate_seal_proofs(
                 registered_proof_seal,
                 registered_aggregation,