Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe how to query ward encounters #37

Merged
merged 8 commits into from
Jan 31, 2023

Conversation

mikajylha
Copy link
Collaborator

No description provided.

@mikajylha mikajylha linked an issue Jan 26, 2023 that may be closed by this pull request
mrinnetmaki
mrinnetmaki previously approved these changes Jan 26, 2023
Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

Still, how about presenting this information as an example instead? And in the introduction of the Encounter just refer to the example that then gives you more insight?

Mika Jylhä added 4 commits January 27, 2023 08:15
Provide more context to encounter intro with an example.

Add encounter example fsh:s.
I can't get it to work. Is there an issue in sushi?
I couldn't get this text to fit nicely in the example. Putting it back to
the main intro text.

Added some stub paragraphs for other relvant parts, so that its clear that
patients in a ward is not the only concern we are trying to adress.
@mikajylha
Copy link
Collaborator Author

mikajylha commented Jan 27, 2023

I had difficulties in moving the markdown description to the example.

I left my failed attempt b4ef2f1 in the commit history if there's time to debug this more later.

Added another heading (which is still at todo stage) to communicate that this resource is much more than just for fetching patients in a ward.

@mikajylha mikajylha mentioned this pull request Jan 27, 2023
@fhir-fi fhir-fi changed the base branch from main to master January 30, 2023 16:53
@fhir-fi fhir-fi dismissed mrinnetmaki’s stale review January 30, 2023 16:53

The base branch was changed.

Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Good stuff, @mikajylha!

use SHOULD instead of weak should.

Fix markdown issues.
@mikajylha mikajylha merged commit 3244745 into master Jan 31, 2023
@mikajylha mikajylha deleted the encounter_managing_organization branch January 31, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Osaston potilaiden hakeminen
2 participants