Start work on medication related resources #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may want to move the info on notable FHIR implementations to a page of its own.
Safety considerations and legal text copied from other IG's (Danish and Swiss ones use the same).
Include a proper menu structure, add content to both the header and footer. Also, strip comments from the config file. They make the file harder to navigate, and are also already a bit outdated. It is better to refer to the specification when figuring out what to use.
When profiles, extensions, and terminology are exposed anyway, there's not much value from the ToC. Also, it is a bit annoying to have a section 0 between 1 and 2... And, the ToC is always available just below the header.
This will keep the directory structure cleaner.
The IG publisher QA report complained: > `fsh-generated/resources/Patient-01234.json` A code with no system has no defined meaning. A system should be provided. So adding one. @Marvasuo can you check whether this is still compliant with CGI's systems?
The title tells IG users what the example is about.
A short version, such as `fi-base-patient` seems to be the international convention.
These do not work as such, without some pre-processing...
Not useful as an example, not referred to by Kanta PHR examples
Now the IG builds. However, all Finnish PHR related stuff is mixed with Fi Base ones. Except for examples, which is what we'd really want...
Still need to filter the profiles from the Profiles view of the IG. Extensions and value sets are probably nice to keep visible?
Don't include the word Profile in titles. It will be clear from the context.
In separate lists. Also add clarifying descriptions to all pages listing artifacts.
Still the template does not pick the headings in the auto-generated ToC...
Based on the title of the profile
No real content yet, just the skeletons. Do we want to include MedicationRequest? Probably not, it was not part of the originally identified resources.
Marvasuo
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No real content yet, just the skeletons. But useful to get in, so people know what's being profiled.
Do we want to include MedicationRequest?
Probably not, it was not part of the originally identified resources.