Skip to content

Commit

Permalink
Enable supports_dynamic_linker feature on darwin
Browse files Browse the repository at this point in the history
The `supports_dynamic_linker` is not turned on, resulting shared library is not producde by cc_library or cc_test

Ref: bazelbuild/bazel#16479
https://github.com/bazelbuild/bazel/blob/c5cb07ac4603cef03d7037d603971e1f4e9184c9/src/main/starlark/builtins_bzl/common/cc/cc_library.bzl#L94
  • Loading branch information
fffonion authored Apr 26, 2024
1 parent 6961212 commit 1cb24ec
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crosstool/cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -2604,6 +2604,7 @@ please file an issue at https://github.com/bazelbuild/apple_support/issues/new
ctx.attr.cpu == "darwin_arm64" or
ctx.attr.cpu == "darwin_arm64e"):
features.append(feature(name = "dynamic_linking_mode"))
features.append(feature(name = "supports_dynamic_linker"))

# macOS artifact name patterns differ from the defaults only for dynamic
# libraries.
Expand Down

0 comments on commit 1cb24ec

Please sign in to comment.