Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for cc_test should mention that the linkstatic default is different on macOS #16479

Open
jfirebaugh opened this issue Oct 14, 2022 · 0 comments
Open

Docs for cc_test should mention that the linkstatic default is different on macOS #16479

jfirebaugh opened this issue Oct 14, 2022 · 0 comments
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)

Comments

@jfirebaugh
Copy link

Description of the bug:

The docs for linkstatic say that the default is linkstatic = False for cc_test targets. This isn't true on macOS because the osx toolchain does not provide a supports_dynamic_linker feature, which is required for linkstatic = False support. See ec55533 and #4341 (comment) for background.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

n/a, docs bug

Which operating system are you running Bazel on?

macOS

What is the output of bazel info release?

release 5.2.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

ec55533
#4341 (comment)
https://bazelbuild.slack.com/archives/CGA9QFQ8H/p1665782748672499

Any other information, logs, or outputs that you want to share?

No response
@ShreeM01 ShreeM01 added type: bug type: documentation (cleanup) team-Rules-CPP Issues for C++ rules untriaged team-Documentation Documentation improvements that cannot be directly linked to other team labels and removed type: documentation (cleanup) team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Oct 15, 2022
@oquenchil oquenchil added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed type: bug untriaged labels Oct 26, 2022
@keertk keertk added the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Jan 10, 2023
@keertk keertk added the help wanted Someone outside the Bazel team could own this label Jan 17, 2023
fffonion added a commit to fffonion/apple_support that referenced this issue Apr 26, 2024
@fffonion
Enable supports_dynamic_linker feature on darwin
1cb24ec 
The `supports_dynamic_linker` is not turned on, resulting shared library is not producde by cc_library or cc_test

Ref: bazelbuild/bazel#16479
https://github.com/bazelbuild/bazel/blob/c5cb07ac4603cef03d7037d603971e1f4e9184c9/src/main/starlark/builtins_bzl/common/cc/cc_library.bzl#L94
@fffonion fffonion mentioned this issue Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jfirebaugh @oquenchil @ShreeM01 @keertk