Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fi.json #37

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Create fi.json #37

merged 4 commits into from
Oct 2, 2023

Conversation

timpeer
Copy link

@timpeer timpeer commented Sep 24, 2022

Just a Finnish translations

Just a Finnish translations, I beein lazy by doing it this way ;D
@fewieden fewieden changed the base branch from master to develop October 16, 2022 14:12
@fewieden
Copy link
Owner

Hi@timpeer, thank you for your contribution. In order to merge your pull request you have to change the following things:

  • Register the new language file in the list here

    MMM-NHL/MMM-NHL.js

    Lines 119 to 125 in 45878a7

    getTranslations() {
    return {
    en: 'translations/en.json',
    de: 'translations/de.json',
    fr: 'translations/fr.json'
    };
    },
  • Add a changelog entry

Please let me know if you need help with that

@fewieden fewieden merged commit 8382209 into fewieden:develop Oct 2, 2023
@fewieden
Copy link
Owner

fewieden commented Oct 2, 2023

@timpeer thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants