This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Allow hyphenated-names in services - fixes #113 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Absolutely! Thanks so much. I'll work on feathersjs-ecosystem/cli#20 and then make a new release. |
|
Wooo! Thanks for doing that @toddgeist. Even a test without asking for it ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to a popular open source project, which is awesome. But if I screwed something up please let me know :-)
There wasn't a test for the complete
importService()function. Nor did I see an obvious place to put one. So instead I added a test foraddImport(), and fixed that so the varName handles hyphenated-names. This seems right to me since I don't think hyphenated-names would be OK in any use ofaddImport()But importService(), has another instance of the same problem. I added the fix there as well, but did NOT add a case that covers that. Not sure where to put that. However all tests do pass!.
comments? is this ok?
Closes feathersjs-ecosystem/cli#19