Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Allow hyphenate generated names #113

Closed
daffl opened this issue Apr 14, 2016 · 3 comments
Closed

Allow hyphenate generated names #113

daffl opened this issue Apr 14, 2016 · 3 comments

Comments

@daffl
Copy link
Member

daffl commented Apr 14, 2016

When the name is also inserted into the code it needs to be _.kebabCased.

@toddgeist
Copy link
Contributor

I was just looking this
https://github.com/feathersjs/generator-feathers/blob/master/generators/service/index.js#L8-L19
Looks like you could use inflect also and it's already in the module

inflect.camelize('message_properties', false); // === 'messageProperties'

@ekryski
Copy link
Member

ekryski commented Apr 14, 2016

We're already doing this for hooks we just forgot to add it for services (and probably models as well).

@toddgeist
Copy link
Contributor

I'll take a stab at this one. Doesn't look too tough. I think I just need to add a test here.

https://github.com/feathersjs/generator-feathers/blob/master/test/transform.test.js#L6-L26

@daffl daffl closed this as completed in 54e12e5 Apr 15, 2016
daffl added a commit that referenced this issue Apr 15, 2016
Allow hyphenated-names in services - fixes #113
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants