Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure jupyter env on AWS via terraform #1077

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Configure jupyter env on AWS via terraform #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions infra/charts/feast/charts/feast-jupyter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ Current chart version is `0.8-SNAPSHOT`
| image.repository | string | `"gcr.io/kf-feast/feast-jupyter"` | Docker image repository |
| image.tag | string | `"develop"` | Image tag |
| replicaCount | int | `1` | Number of pods that will be created |
| envOverrides | object | `{}` | Extra environment variables to set |
9 changes: 9 additions & 0 deletions infra/charts/feast/charts/feast-jupyter/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ spec:
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /etc/secrets/google/{{ .Values.gcpServiceAccount.existingSecret.key }}
{{- end }}
{{- range $key, $value := .Values.envOverrides }}
- name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
{{- if eq (kindOf $value) "map" }}
valueFrom:
{{- toYaml $value | nindent 12}}
{{- else }}
value: {{ $value | quote }}
{{- end }}
{{- end }}
ports:
- name: http
containerPort: 8888
Expand Down
16 changes: 16 additions & 0 deletions infra/terraform/aws/helm.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,22 @@ locals {
redis_port = 6379
}
}

"feast-jupyter" = {
"envOverrides" = {
feast_redis_host = module.redis.endpoint
feast_redis_port = 6379
feast_redis_ssl = true
feast_emr_cluster_id = (length(aws_emr_cluster.persistent_cluster) > 0) ? aws_emr_cluster.persistent_cluster[0].id : null
feast_emr_region = var.region
spark_staging_location = "s3://${aws_s3_bucket.feast_bucket.id}/artifacts/"
feast_emr_log_location = "s3://${aws_s3_bucket.feast_bucket.id}/emr-logs/"
feast_spark_launcher = "emr"
feast_historical_feature_output_location = "s3://${aws_s3_bucket.feast_bucket.id}/out/"
feast_historical_feature_output_format = "parquet"
kafka_brokers = aws_msk_cluster.msk.bootstrap_brokers
}
}
}
}
}
Expand Down