Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure jupyter env on AWS via terraform #1077

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

oavdeev
Copy link
Collaborator

@oavdeev oavdeev commented Oct 20, 2020

What this PR does / why we need it:
Automatically provide all the necessary settings on AWS to the jupyter pod via terraform.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@oavdeev
Copy link
Collaborator Author

oavdeev commented Oct 21, 2020

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 21, 2020
@woop
Copy link
Member

woop commented Oct 21, 2020

/lgtm

Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@oavdeev oavdeev force-pushed the feast-jupyter-config branch from caf6a65 to 919e78c Compare October 21, 2020 14:08
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Oct 21, 2020
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop changed the title configure jupyter env on AWS via terraform Configure jupyter env on AWS via terraform Oct 21, 2020
@woop woop merged commit 930bb2c into feast-dev:master Oct 21, 2020
@oavdeev oavdeev deleted the feast-jupyter-config branch October 21, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants