Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove big bang mode #89

Merged
merged 10 commits into from
Jun 17, 2020
Merged

remove big bang mode #89

merged 10 commits into from
Jun 17, 2020

Conversation

monxxi
Copy link
Collaborator

@monxxi monxxi commented Jun 12, 2020 •
edited
Loading

@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch 2 times, most recently from dfc954a to 2a59fba Compare June 15, 2020 11:14
@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch 2 times, most recently from 08bc33b to fe71c17 Compare June 15, 2020 16:28
@monxxi monxxi marked this pull request as ready for review June 15, 2020 17:33
@monxxi monxxi marked this pull request as draft June 15, 2020 17:37
@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch from 0e52d6e to 020e628 Compare June 15, 2020 17:43
@monxxi monxxi marked this pull request as ready for review June 15, 2020 18:50
@monxxi monxxi requested a review from fdelbrayelle June 15, 2020 18:50
fdelbrayelle
fdelbrayelle requested changes Jun 16, 2020
View reviewed changes
fdelbrayelle
fdelbrayelle requested changes Jun 16, 2020
View reviewed changes
Copy link
Owner

@fdelbrayelle fdelbrayelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove application-kafka.yml.ejs and this comment part in utils.js: " (see also application-kafka.yml.ejs)"

monxxi and others added 2 commits June 16, 2020 14:03
@monxxi @fdelbrayelle
Update README.md
9b6e733 
Co-authored-by: François Delbrayelle <fdelbrayelle@gmail.com>
@monxxi @fdelbrayelle
Update USE_CASES.md
0b8802c 
Co-authored-by: François Delbrayelle <fdelbrayelle@gmail.com>
@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch 2 times, most recently from 2388ce4 to c42d9b1 Compare June 16, 2020 12:39
@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch from c42d9b1 to f5ca1f5 Compare June 16, 2020 13:04
@fdelbrayelle fdelbrayelle self-requested a review June 16, 2020 13:20
@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch 4 times, most recently from 8ceaba2 to e904a0a Compare June 17, 2020 10:13
@monxxi monxxi force-pushed the feature/87-removeBBmode-and-IncludeCLeanOption branch from e904a0a to fa8cd10 Compare June 17, 2020 10:20
@monxxi monxxi merged commit c46090b into fdelbrayelle:master Jun 17, 2020
@monxxi monxxi linked an issue Jun 17, 2020 that may be closed by this pull request
Remove modes and clean code #87
Closed
5 tasks
@fdelbrayelle fdelbrayelle mentioned this pull request Jun 17, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelbrayelle fdelbrayelle fdelbrayelle approved these changes

Assignees

@monxxi monxxi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove modes and clean code
2 participants
@monxxi @fdelbrayelle