Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove modes and clean code #87

Closed
5 tasks done
fdelbrayelle opened this issue Jun 11, 2020 · 1 comment · Fixed by #89
Closed
5 tasks done

Remove modes and clean code #87

fdelbrayelle opened this issue Jun 11, 2020 · 1 comment · Fixed by #89
Assignees
@monxxi
Labels
enhancement New feature or request next release

Comments

@fdelbrayelle
Copy link
Owner

fdelbrayelle commented Jun 11, 2020 •
edited by monxxi
Loading

Overview of the feature request

The objective is to remove the two modes (Big Bang and Incremental) to have the same process:

  • add a new prompt option to clean or no the previous configuration
  • have only one process
  • update tests in consequence
  • update doc (README.md and USE_CASES.md) in consequence
Motivation for or Use Case

Improve readability and maintenance of the module source code.

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@fdelbrayelle fdelbrayelle added the enhancement New feature or request label Jun 11, 2020
@monxxi monxxi linked a pull request Jun 17, 2020 that will close this issue
remove big bang mode #89
Merged
4 tasks
@fdelbrayelle
Copy link
Owner Author

Fixed by #89, thank you @monxxi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monxxi monxxi

Labels
enhancement New feature or request next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove big bang mode monxxi/generator-jhipster-kafka
2 participants
@fdelbrayelle @monxxi