Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateEndpointConfigBase64Payload needs to use generateEndpointConfigClientId #532

Merged
merged 4 commits into from
Dec 8, 2022
Merged

generateEndpointConfigBase64Payload needs to use generateEndpointConfigClientId #532

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4d87d1
x
johnrandolph Dec 7, 2022
c0bd184
x
johnrandolph Dec 8, 2022
c146f57
x
johnrandolph Dec 8, 2022
c44972a
x
johnrandolph Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ private String generateEndpointConfigClientId() {

private String generateEndpointConfigBase64Payload(String hostname) {
String payload = String.format(
ENDPOINT_CONFIG_HOSTNAME_PAYLOAD, ENDPOINT_CONFIG_CLIENT_ID, hostname);
ENDPOINT_CONFIG_HOSTNAME_PAYLOAD, generateEndpointConfigClientId(), hostname);
grafnu marked this conversation as resolved.
Show resolved Hide resolved
String base64Payload = Base64.getEncoder().encodeToString(payload.getBytes());
return SemanticValue.describe("endpoint_base64_payload", base64Payload);
}
Expand Down Expand Up @@ -99,7 +99,8 @@ public void endpoint_config_connection_success_reconnect() {
return phase != null
&& phase.equals(BlobPhase.FINAL)
&& stateStatus.category.equals(SYSTEM_CONFIG_APPLY)
&& stateStatus.level == Level.NOTICE.value();
&& stateStatus.level == Level.NOTICE.value()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that the status in the blob block was as intended. The system status is not always indicative of what the blob is doing... the specific problem here was that the blob was reporting an error that was not checked by this condition -- this change doesn't fix that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to check blob state message for success.

&& stateStatus.message.equals("success");
});
}

Expand Down