generateEndpointConfigBase64Payload needs to use generateEndpointConfigClientId #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still draft... is it ready for review? |
grafnu
reviewed
Dec 8, 2022
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Show resolved
Hide resolved
grafnu
reviewed
Dec 8, 2022
| @@ -99,7 +99,8 @@ public void endpoint_config_connection_success_reconnect() { | |||
| return phase != null | |||
| && phase.equals(BlobPhase.FINAL) | |||
| && stateStatus.category.equals(SYSTEM_CONFIG_APPLY) | |||
| && stateStatus.level == Level.NOTICE.value(); | |||
| && stateStatus.level == Level.NOTICE.value() | |||
There was a problem hiding this comment.
I meant that the status in the blob block was as intended. The system status is not always indicative of what the blob is doing... the specific problem here was that the blob was reporting an error that was not checked by this condition -- this change doesn't fix that.
There was a problem hiding this comment.
Changed this to check blob state message for success.
grafnu
approved these changes
Dec 8, 2022
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this means that pubber was potentially a false positive on restart?