Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for VCL Snippets #93

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Add support for VCL Snippets #93

merged 2 commits into from
Sep 11, 2018

Conversation

hynd
Copy link
Contributor

@hynd hynd commented Sep 4, 2018

Closes #7.

@ghost ghost added the size/XL label Sep 4, 2018
@drpebcak drpebcak mentioned this pull request Sep 10, 2018
Closed
lanej
lanej approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@lanej lanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍

note: regular snippet support only. Dynamic support would require adding an additional attribute

https://docs.fastly.com/api/config#snippet

@lanej lanej merged commit 1020833 into fastly:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanej lanej lanej approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hynd @lanej