Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastly][fastly_service_v1] support vcl snippets #7

Closed
hashibot opened this issue Jun 13, 2017 · 11 comments
Closed

[fastly][fastly_service_v1] support vcl snippets #7

hashibot opened this issue Jun 13, 2017 · 11 comments
Labels
enhancement New feature or request

Comments

@hashibot
Copy link

This issue was originally opened by @mtougeron as hashicorp/terraform#14600. It was migrated here as part of the provider split. The original body of the issue is below.


It would be great if the fastly_service_v1 resource supported the VCL Snippets. The way the fastly_service_v1 resource works now we have to update the entire VCL, including the boilerplate, in order to modify just part of the logic (e.g., a Header). This prevents us from being able to use the VCL Snippets and simplifying our code-base & workflow.

@hashibot hashibot added the enhancement New feature or request label Jun 13, 2017
@lnrdll
Copy link

lnrdll commented Oct 3, 2017

Any updates on this feature?

@thommahoney
Copy link
Member

@rlunardelli I can prioritize this work next.

@rtlechow
Copy link

Is this close? Just wondering if I should bother rewriting snippets into custom VCL. Thanks!

@jasonkuhrt
Copy link

We need snippets because there is a hard-limit of 3mb on custom vcl but snippets have a soft limit of 1mb. The website says to contact support to get it increased and from my conversation with support they will increase it for everyone sooner or later while the custom vcl limit is firm.

@thommahoney
Copy link
Member

@jasonkuhrt Do you use Dynamic Snippets at all or would support for regular (ie. versioned) Snippets suit for your workflow?

@jasonkuhrt
Copy link

jasonkuhrt commented Mar 26, 2018

@thommahoney I think my current use-case will be served by regular snippets just fine as I would put them in custom vcl if I could except there is a 3mb limit. I'm working with Fastly support right now to increase the snippet limit for my fastly services.

@siwyd
Copy link

siwyd commented May 4, 2018

Definitely a big fan of getting this implemented in the provider. It will make our Terraform configs for a lot of services a lot easier to read when we can use snippets instead of having to define custom VCL.

@javapapo
Copy link

+1 yes..it would be really nice to have!

@Nightghos
Copy link

+1 pleasssee!

@cruzanmo
Copy link

cruzanmo commented Jul 6, 2018

+1

hynd added a commit to hynd/terraform-provider-fastly that referenced this issue Sep 4, 2018
@drpebcak
Copy link

Is there something blocking #93 from being merged?

@lanej lanej closed this as completed in #93 Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants