Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gcs): project_id should be optional #693

Merged
merged 2 commits into from
May 12, 2023
Merged

fix(gcs): project_id should be optional #693

merged 2 commits into from
May 12, 2023

Conversation

Integralist
Copy link
Collaborator

No description provided.

@Integralist Integralist requested a review from bowrocker May 12, 2023 08:01
bowrocker
bowrocker approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@bowrocker bowrocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

+1

@Integralist Integralist merged commit 6a8fe30 into main May 12, 2023
@Integralist Integralist deleted the integralist/google-project-id branch May 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowrocker bowrocker bowrocker approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @bowrocker