fix(gcs): project_id should be optional (#693)

* fix(gcs): project_id should be optional * docs(gcs): project_id should be optional
fastly · May 12, 2023 · 6a8fe30 · 6a8fe30
1 parent a7557f3
commit 6a8fe30
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/resources/service_compute.md b/docs/resources/service_compute.md
@@ -336,7 +336,6 @@ Required:
 
 - `bucket_name` (String) The name of the bucket in which to store the logs
 - `name` (String) A unique name to identify this GCS endpoint. It is important to note that changing this attribute will delete and recreate the resource
-- `project_id` (String) The ID of your Google Cloud Platform project
 
 Optional:
 
@@ -346,6 +345,7 @@ Optional:
 - `message_type` (String) How the message should be formatted. Can be either `classic`, `loggly`, `logplex` or `blank`. Default is `classic`
 - `path` (String) Path to store the files. Must end with a trailing slash. If this field is left empty, the files will be saved in the bucket's root path
 - `period` (Number) How frequently the logs should be transferred, in seconds (Default 3600)
+- `project_id` (String) The ID of your Google Cloud Platform project
 - `secret_key` (String, Sensitive) The secret key associated with the target gcs bucket on your account. You may optionally provide this secret via an environment variable, `FASTLY_GCS_SECRET_KEY`. A typical format for the key is PEM format, containing actual newline characters where required
 - `timestamp_format` (String) The `strftime` specified timestamp formatting (default `%Y-%m-%dT%H:%M:%S.000`)
 - `user` (String) Your Google Cloud Platform service account email address. The `client_email` field in your service account authentication JSON. You may optionally provide this via an environment variable, `FASTLY_GCS_EMAIL`.

diff --git a/docs/resources/service_vcl.md b/docs/resources/service_vcl.md
@@ -678,7 +678,6 @@ Required:
 
 - `bucket_name` (String) The name of the bucket in which to store the logs
 - `name` (String) A unique name to identify this GCS endpoint. It is important to note that changing this attribute will delete and recreate the resource
-- `project_id` (String) The ID of your Google Cloud Platform project
 
 Optional:
 
@@ -691,6 +690,7 @@ Optional:
 - `path` (String) Path to store the files. Must end with a trailing slash. If this field is left empty, the files will be saved in the bucket's root path
 - `period` (Number) How frequently the logs should be transferred, in seconds (Default 3600)
 - `placement` (String) Where in the generated VCL the logging call should be placed.
+- `project_id` (String) The ID of your Google Cloud Platform project
 - `response_condition` (String) Name of a condition to apply this logging.
 - `secret_key` (String, Sensitive) The secret key associated with the target gcs bucket on your account. You may optionally provide this secret via an environment variable, `FASTLY_GCS_SECRET_KEY`. A typical format for the key is PEM format, containing actual newline characters where required
 - `timestamp_format` (String) The `strftime` specified timestamp formatting (default `%Y-%m-%dT%H:%M:%S.000`)

diff --git a/fastly/block_fastly_service_logging_gcs.go b/fastly/block_fastly_service_logging_gcs.go
@@ -84,7 +84,7 @@ func (h *GCSLoggingServiceAttributeHandler) GetSchema() *schema.Schema {
 		},
 		"project_id": {
 			Type:        schema.TypeString,
-			Required:    true,
+			Optional:    true,
 			Description: "The ID of your Google Cloud Platform project",
 		},
 		"secret_key": {