-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: check scripts #922
ci: check scripts #922
Conversation
fdac641
to
518b3fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 1957 1957
Lines 209797 209797
Branches 886 885 -1
==========================================
- Hits 209087 209084 -3
- Misses 690 693 +3
Partials 20 20
|
awaiting merge of #915 |
I don't know why but the results differs when I run Edit1:It has something todo with the glob pattern which is not fully resolved in CI Edit2:Yeah that looks like a bug, because Edit3:I use config files now, as these seems to work 🤷 |
Depending on OSes you have to manually enable glob patterns, but I like the configs more anyway. https://unix.stackexchange.com/questions/388695/how-to-turn-globbing-on-and-off |
This looks like the perfect place for using extends. |
I didn't use it for |
#915 is merged. |
closes #917