Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check whether scripts still compile #917

Closed
ST-DDT opened this issue May 3, 2022 · 3 comments · Fixed by #922
Closed

ci: check whether scripts still compile #917

ST-DDT opened this issue May 3, 2022 · 3 comments · Fixed by #922
Assignees
Labels
c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug

Comments

@ST-DDT
Copy link
Member

ST-DDT commented May 3, 2022

Clear and concise description of the problem

In #910 I removed code from the sources, that were used in the scripts.
Unfortunately, there isn't a build step that checks them with TS powers.

Suggested solution

Check the types in the ci pipeline.

Alternative

Run all scripts (#813), however that still wouldn't catch most type errors.

Additional context

No response

@ST-DDT ST-DDT added c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels May 3, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented May 3, 2022

I'm not sure, how to proceed here. Any input is welcome.

@Shinigami92
Copy link
Member

Duplicate of #813 ?

@ST-DDT
Copy link
Member Author

ST-DDT commented May 3, 2022

#813 is for actually running them, as mentioned above, that wouldn't necessarily uncover all type errors.

@Shinigami92 Shinigami92 self-assigned this May 4, 2022
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap May 4, 2022
Repository owner moved this from In Progress to Done in Faker Roadmap May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants