fix(person): fix duplicate last names in full name generation

[0916dhkim]

Fixes #1817

As Is

faker.person.fullName uses mustache templates from each locale to generate a full name. When the template contains multiple last names, the same last name is repeated. Same bug happens to multiple first names. This is because firstName and lastName are generated before the template replacement unlike middleName or suffix which are generated on demand.

To Be

Make firstName and lastName get generated on demand similar to middleName. Only fallback to options.firstName and options.lastName when those are supplied.

[codecov]

Codecov Report

Merging #1822 (e49a0a1) into next (d5b78c7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1822      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files        2347     2347              
  Lines      235657   235657              
  Branches     1145     1142       -3     
==========================================
- Hits       234811   234788      -23     
- Misses        824      847      +23     
  Partials       22       22              

Impacted Files	Coverage Δ
src/modules/person/index.ts	99.72% <100.00%> (ø)
src/modules/internet/user-agent.ts	89.64% <0.00%> (-6.81%)	⬇️

[ST-DDT]

Could you please share your insights on the last name matter a bit?
Do these languages have two distinct last names (e.g. mothers and fathers last name) or one last name consisting of multiple parts (space or hyphen separated)?
E.g. in Germany you can decide to add your spouses name to your name, but then you have a new single last name that you have use then.
The individual parts are no longer relevant excepts for personal reasons.

[madcampos]

Hi @ST-DDT just chiming in to give an insight for Brazilian Portuguese.

It is a tradition that the children get both parents last names, but it varies from place to place and is not a hard rule.

For example, my mother has a super simple name, Lucrécia Dilda. When my parents were married, she had my father's last name too.

On the other hand, my father has the same name of my grandfather, Francisco Aurélio da Silva Campos Filho. His first name would be "Francisco Aurélio", then the rest is his last name, and "Filho" means "son" to mark he has his father's name.

I got both last names, so my full name is Marco Aurélio Dilda Campos.

So yeah, it can be multiple different names.

[ST-DDT]

Thanks @madcampos for your input.

I got both last names, so my full name is Marco Aurélio Dilda Campos.

So yeah, it can be multiple different names.

Just for clarification, is "Dilda Campos" your last name or "Dilda" AND "Campos"? Is it possible for you to flip them the other way round e.g. "Campos Dilda"?
How is it handled in web forms? Do you have two inputs for the last name or do you put both in one?

[madcampos]

@ST-DDT So, to be super semantic here...

In Brazil the whole thing is considered your surname, in that case "Dilda Campos", and last name would be your very last name, in this case only "Campos". I cannot flip them around.

In web forms outside of Brazil I use my very first and very last name and omit everything else, so my name would be only "Marco Campos".

For forms in Brazil it is common to have a single field for full name, if it happens to be two fields, then I would input "Marco Aurélio" as first name/given name and "Dilda Campos" as last name/surname

[matthewmayer]

Note that the naming of the Faker methods isn't perfect anyway, "lastName" should probably be familyName and "firstName" should be givenName as for example in Chinese the family name comes first.

[ST-DDT]

Team Decision

Closing in favor of #1819.