Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double last names in some locales #1817

Closed
9 of 10 tasks
matthewmayer opened this issue Feb 8, 2023 · 3 comments · Fixed by #1819
Closed
9 of 10 tasks

Double last names in some locales #1817

matthewmayer opened this issue Feb 8, 2023 · 3 comments · Fixed by #1819
Labels
c: bug Something isn't working m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented Feb 8, 2023

Pre-Checks

Describe the bug

#1637 has caused a problem in some locales for example es which have name patterns like

'{{person.firstName}} {{person.lastName}} {{person.lastName}}'

Minimal reproduction code

const {faker} = require("@faker-js/faker")
faker.locale = "es"
faker.person.fullName() //'Anni Cervantes Cervantes'

Additional Context

No response

Environment Info

System:
    OS: macOS 13.1
    CPU: (8) x64 Apple M1
    Memory: 37.86 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.21.2 - /usr/local/bin/node
    npm: 8.19.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 110.0.5481.77
    Firefox: 109.0.1
    Safari: 16.2

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

pnpm

@0916dhkim
Copy link

Opened a bugfix PR #1822 👍

@matthewmayer
Copy link
Contributor Author

We now have three potential solutions in #1818 #1819 and #1822

@faker-js/maintainers in the next meeting maybe you can discuss which direction you prefer.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: person Something is referring to the person module labels Feb 12, 2023
@ST-DDT ST-DDT removed the s: pending triage Pending Triage label Feb 12, 2023
@ST-DDT ST-DDT moved this to In Progress in Faker Roadmap Feb 12, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Feb 12, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Feb 16, 2023

Team Decision

We decided on #1819 (with changes).

@github-project-automation github-project-automation bot moved this from In Progress to Done in Faker Roadmap Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
3 participants