Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Fix CI by fully specifying Python env and adjusting range on flakey #350

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Fix CI by fully specifying Python env and adjusting range on flakey #350

merged 2 commits into from
Dec 15, 2022

Conversation

cdmatters
Copy link
Contributor

test.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2022
@cdmatters cdmatters requested a review from samvelyan December 14, 2022 14:54
@cdmatters cdmatters force-pushed the eric/more-gh-actions branch from 63ad562 to 779d0a5 Compare December 14, 2022 15:00
@cdmatters
Can ignore B905 for flake, since it requests a "strict=True" parameter
f1ee476 
for the built-in `zip` and this is not compatible with Python<3.10.
@cdmatters
Copy link
Contributor Author

This change emerged because ubuntu-latest on GH actions moved from 20.04 to 22.04 and there is no 3.6 available for it. We will keep on this version for now.

@cdmatters
Copy link
Contributor Author

See here

@cdmatters cdmatters merged commit 77f23cf into main Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samvelyan samvelyan samvelyan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdmatters @samvelyan @facebook-github-bot