Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Commit

Permalink
Fix CI by fully specifying Python env and adjusting range on flakey (#…
Browse files Browse the repository at this point in the history
…350)

* Fix CI by fully specifying Python env and adjusting range on flakey
test.

* Can ignore B905 for flake, since it requests a "strict=True" parameter
for the built-in `zip` and this is not compatible with Python<3.10.
  • Loading branch information
cdmatters authored Dec 15, 2022
1 parent 2fa1be5 commit 77f23cf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[flake8]
ignore = E203, E266, E501, E731, W503, C901, B008
ignore = E203, E266, E501, E731, W503, C901, B008, B905
# 80 to use as a soft test
max-line-length = 80
max-complexity = 18
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9"]
os: [ubuntu-latest, macos-latest]
os: [ubuntu-20.04, macos-latest]
fail-fast: false
steps:
- name: Setup Python ${{ matrix.python-version }} env
Expand Down
2 changes: 1 addition & 1 deletion nle/tests/test_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def convert_n_times(n):
# After warmup the last few iterations should be constant memory
memory_array = np.array(memory_list[5:])
memory_change = (memory_array / memory_array[0]) - 1
assert max(memory_change) < 0.001 # 0.1 per cent
assert max(memory_change) < 0.002 # 0.2 per cent

def test_ttyrec_with_extra_data(self, seq_length=500):
converter = Converter(ROWS, COLUMNS, TTYREC_V1)
Expand Down

0 comments on commit 77f23cf

Please sign in to comment.