Relax column count check in PrestoSerializer #7524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D51230660 |
xiaoxmeng
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
@mbasmanova LGTM. Is it possible to add a unit test to catch this behavior? Thanks!
Summary: Add test to verify error messages when RowType used to serialized data doesn't match the RowType used to deserialize. Also, make these failure user errors. Reviewed By: xiaoxmeng Differential Revision: D51256840 Pulled By: mbasmanova
Summary: Some call sites deserialize only a subset of columns. Relax the check to avoid breaking these. Investigate and fix these call sites, then restore the check as a follow-up. Reviewed By: xiaoxmeng Differential Revision: D51230660
a8e6f13 to
0b3bd40
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51230660 |
|
This pull request has been merged in b417572. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some call sites deserialize only a subset of columns. Relax the check to avoid
breaking these. Investigate and fix these call sites, then restore the check as
a follow-up.
Differential Revision: D51230660