Skip to content

Commit

Permalink
Relax column count check in PrestoSerializer (#7524)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #7524

Some call sites deserialize only a subset of columns. Relax the check to avoid
breaking these. Investigate and fix these call sites, then restore the check as
a follow-up.

Reviewed By: xiaoxmeng

Differential Revision: D51230660

fbshipit-source-id: de53d4e4749b9a878eefba6312226764643e576b
  • Loading branch information
mbasmanova authored and facebook-github-bot committed Nov 13, 2023
1 parent 8b3bab9 commit b417572
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion velox/serializers/PrestoSerializer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2339,7 +2339,8 @@ void PrestoVectorSerde::deserialize(
const auto& childTypes = type->asRow().children();
if (!needCompression(*codec)) {
const auto numColumns = source->read<int32_t>();
VELOX_USER_CHECK_EQ(
// TODO Fix call sites and tighten the check to _EQ.
VELOX_USER_CHECK_GE(
numColumns,
type->size(),
"Number of columns in serialized data doesn't match "
Expand Down

0 comments on commit b417572

Please sign in to comment.