New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json_format Presto function (#3398) #3525

Closed

arpitporwal2293 wants to merge 1 commit into facebookincubator:main from arpitporwal2293:export-D42060671

Contributor

arpitporwal2293 commented Dec 15, 2022

Summary:
Pull Request resolved: #3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

facebook-github-bot added the CLA Signed label

netlify bot commented Dec 15, 2022 •

edited

Loading

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	`76ec7cc`
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/63b5ce3807e58d0008f8e3a8

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Dec 15, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

067ccde

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 6b652de2fda6abff7bbde3465307de5fdf311787

arpitporwal2293 force-pushed the export-D42060671 branch from 0dd09cc to 067ccde Compare

December 15, 2022 06:19

Contributor

facebook-github-bot commented Dec 15, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

523918a

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 095c3bb32951b1578476040b0556425f77e29e6a

arpitporwal2293 force-pushed the export-D42060671 branch from 067ccde to 523918a Compare

December 15, 2022 09:53

Contributor

facebook-github-bot commented Dec 15, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

mbasmanova reviewed

View reviewed changes

Contributor

mbasmanova left a comment

@arpitporwal2293 Looks good to me. Please, run Fuzzer tests as described in https://github.com/facebookincubator/velox/blob/main/CONTRIBUTING.md#prestos-sql-functions and report the results.

velox/functions/prestosql/tests/JsonFunctionsTest.cpp Outdated Show resolved Hide resolved

velox/functions/prestosql/tests/JsonFunctionsTest.cpp Outdated Show resolved Hide resolved

Contributor

facebook-github-bot commented Dec 16, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

c53c6b6

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 7806d25d21ddff541e428b8f1077d6375bd30154

arpitporwal2293 force-pushed the export-D42060671 branch from 523918a to c53c6b6 Compare

December 16, 2022 21:18

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

edf57a2

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 4e59f9ce0de8135d3b046432cc591a6e73561d96

Contributor

facebook-github-bot commented Dec 20, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 force-pushed the export-D42060671 branch from c53c6b6 to edf57a2 Compare

December 20, 2022 02:33

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

ceb43b8

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 03b6db4247042fd732c1c32f4ef95cd47a828a68

arpitporwal2293 force-pushed the export-D42060671 branch from edf57a2 to ceb43b8 Compare

December 20, 2022 19:21

Contributor

facebook-github-bot commented Dec 20, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

17c9703

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 9044a8a1d69c7abab51d95ea64384f5a877c7698

Contributor

facebook-github-bot commented Dec 21, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 force-pushed the export-D42060671 branch from ceb43b8 to 17c9703 Compare

December 21, 2022 02:33

mbasmanova reviewed

View reviewed changes

Contributor

mbasmanova left a comment

@arpitporwal2293 Thank you for iterating on this PR. Some comments.

velox/docs/functions/json.rst Outdated Show resolved Hide resolved

velox/docs/functions/json.rst Outdated Show resolved Hide resolved

velox/functions/prestosql/tests/JsonFunctionsTest.cpp Show resolved Hide resolved

velox/functions/prestosql/tests/JsonFunctionsTest.cpp Show resolved Hide resolved

mbasmanova requested a review from kagamiori

December 21, 2022 06:37

Contributor

facebook-github-bot commented Dec 22, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

ee33bea

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: eeaf6d49328d3e194eb3847be38f71f2f9ae0a6d

arpitporwal2293 force-pushed the export-D42060671 branch from 17c9703 to ee33bea Compare

December 22, 2022 02:56

mbasmanova reviewed

View reviewed changes

velox/functions/prestosql/tests/JsonFunctionsTest.cpp Outdated Show resolved Hide resolved

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

3a19b10

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: d4bdf41a86d435acd519a4ece105bb0cec4002bd

arpitporwal2293 force-pushed the export-D42060671 branch from ee33bea to 3a19b10 Compare

December 22, 2022 23:11

Contributor

facebook-github-bot commented Dec 22, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

25f8ad3

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Differential Revision: D42060671

fbshipit-source-id: 4d747d7974f10cda4831d4008312a166de626cd2

arpitporwal2293 force-pushed the export-D42060671 branch from 3a19b10 to 25f8ad3 Compare

December 22, 2022 23:18

Contributor

facebook-github-bot commented Dec 22, 2022

This pull request was exported from Phabricator. Differential Revision: D42060671

mbasmanova approved these changes

View reviewed changes

Contributor

mbasmanova left a comment

@arpitporwal2293 Thank you, Arpit.

arpitporwal2293 force-pushed the export-D42060671 branch from 25f8ad3 to 45dafee Compare

January 3, 2023 19:18

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

45dafee

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Reviewed By: mbasmanova

Differential Revision: D42060671

fbshipit-source-id: b12fe8c0c2a1757adbe446fd3943283311dbb13a

Contributor

facebook-github-bot commented Jan 3, 2023

This pull request was exported from Phabricator. Differential Revision: D42060671

1 similar comment

Contributor

facebook-github-bot commented Jan 4, 2023

This pull request was exported from Phabricator. Differential Revision: D42060671

arpitporwal2293 pushed a commit to arpitporwal2293/velox that referenced this pull request


          Add json_format Presto function (facebookincubator#3525)

7bd982c

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Reviewed By: mbasmanova

Differential Revision: D42060671

fbshipit-source-id: 4db561f302534cf9661bd086e161d83c9b0dbfc0

arpitporwal2293 force-pushed the export-D42060671 branch from 45dafee to 7bd982c Compare

January 4, 2023 18:53


          Add json_format Presto function (facebookincubator#3525)

76ec7cc

Summary:
Pull Request resolved: facebookincubator#3525

Pull Request resolved: facebookincubator#3398
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format

Reviewed By: mbasmanova

Differential Revision: D42060671

fbshipit-source-id: 806f9a2b8d20ee23558ee2f72112d8f33ac289ac

arpitporwal2293 force-pushed the export-D42060671 branch from 7bd982c to 76ec7cc Compare

January 4, 2023 19:06

Contributor

facebook-github-bot commented Jan 4, 2023

This pull request was exported from Phabricator. Differential Revision: D42060671

facebook-github-bot closed this in

05e5aae

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Jan 4, 2023

This pull request has been merged in 05e5aae.

mbasmanova mentioned this pull request

Add Presto functions #2262

Open

marin-ma added a commit to marin-ma/velox-oap that referenced this pull request


          [Core] Shuffle the configured local directories for local spills (fac…

9cd88de

…ebookincubator#3525)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged