Added json_format udf to Velox (#1567) #3398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 1, 2022
Summary: Pull Request resolved: facebookincubator#3398 Pull Request resolved: facebookincubator#1567 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: 6c7fd54269ab2b34bb494504da5534c62e8ce5ba
da5d2b8 to
210f7da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 1, 2022
Summary: Pull Request resolved: facebookincubator#3398 Pull Request resolved: facebookincubator#1567 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: ecfd38c347d4d99dad39ca2b7f40462dd7b47bdc
210f7da to
5accb77
Compare
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 1, 2022
Summary: Pull Request resolved: facebookincubator#3398 Pull Request resolved: facebookincubator#1567 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: 3861f77f6cf24962a8930e0ec5358144d5d88e6e
5accb77 to
941ff2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 2, 2022
Summary: Pull Request resolved: facebookincubator#3398 Pull Request resolved: facebookincubator#1567 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: 92ce819c681669af1e5206719079a5fe888d8e12
941ff2c to
c27a3cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
aditi-pandit
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Thanks for adding this function ! This code looks good overall.
Please can you add the description of this function to json.rst
c27a3cf to
146fd6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 3, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: 9772b3e9e8795638f54d330f5bd186736031bd3c
146fd6e to
bbd0e1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 3, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: 50f570c735a538ea17513befcaa1d2f765e8cf53
bbd0e1a to
5bdf28f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 6, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: e84f71dfc6aae4e3ec7f1f4faa254bd897571df2
5bdf28f to
eb5033b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 6, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: c65c0459ce0f5d904960d69ade594469726783ef
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 9, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: e8fe1220aec6deed6d3971aa53d57881b040130e
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
e939517 to
e1c2fc0
Compare
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 9, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D41643635 fbshipit-source-id: fce0a46915b59cf41619b68d17e9cdc9d190dfad
e1c2fc0 to
0b3a8e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: kagamiori Differential Revision: D41643635 fbshipit-source-id: adf4234bd52520ea63762b459549445afdba2a20
|
This pull request was exported from Phabricator. Differential Revision: D41643635 |
0b3a8e8 to
1f3fed8
Compare
|
This pull request has been merged in e2802d7. |
|
This pull request has been reverted by f020d3e. |
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 15, 2022
Summary: Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: f5e3dd9b1694b40c6299d65f7c9ae7852ff893f7
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 15, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 6b652de2fda6abff7bbde3465307de5fdf311787
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 15, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 095c3bb32951b1578476040b0556425f77e29e6a
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 16, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 7806d25d21ddff541e428b8f1077d6375bd30154
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 20, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 4e59f9ce0de8135d3b046432cc591a6e73561d96
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 20, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 03b6db4247042fd732c1c32f4ef95cd47a828a68
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 21, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 9044a8a1d69c7abab51d95ea64384f5a877c7698
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 22, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: eeaf6d49328d3e194eb3847be38f71f2f9ae0a6d
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 22, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: d4bdf41a86d435acd519a4ece105bb0cec4002bd
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Dec 22, 2022
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Differential Revision: D42060671 fbshipit-source-id: 4d747d7974f10cda4831d4008312a166de626cd2
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: b12fe8c0c2a1757adbe446fd3943283311dbb13a
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Jan 4, 2023
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: 4db561f302534cf9661bd086e161d83c9b0dbfc0
arpitporwal2293
pushed a commit
to arpitporwal2293/velox
that referenced
this pull request
Jan 4, 2023
Summary: Pull Request resolved: facebookincubator#3525 Pull Request resolved: facebookincubator#3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: 806f9a2b8d20ee23558ee2f72112d8f33ac289ac
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
Summary: Pull Request resolved: #3525 Pull Request resolved: #3398 Add 'json_format' udf to prestosql. Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format Reviewed By: mbasmanova Differential Revision: D42060671 fbshipit-source-id: 5800ef5aa26420d2294c5a4c89047d680a502b6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #1567
Add 'json_format' udf to prestosql.
Doc: https://prestodb.io/docs/current/functions/json.html?highlight=json_format#json_format
Differential Revision: D41643635