Replace SimpleVector metadata with strongly typed SimpleVectorStats #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D35363043 |
kevinwilfong
added a commit
to kevinwilfong/velox
that referenced
this pull request
Apr 11, 2022
…acebookincubator#1347) Summary: Pull Request resolved: facebookincubator#1347 SimpleVector uses a string-ly typed map to store metadata. This seems to be used primarily for storing min/max stats as well as the bias for BiasVectors. This is inefficient because we end up de/serializing back and forth from strings, and doesn't work for all types (e.g. opaque types). This causes issues in VectorMaker as it tries to initialize stats when creating vectors, so we can't create vectors of Opaque types. Since SimpleVector is templated on the underlying type, I add a SimpleVectorStats object, also templated on this type, and pass this to the vector's constructor instead of the map of strings. This way min/max don't need to be serialized/deserialized, and it works for any type. Reviewed By: laithsakka Differential Revision: D35363043 fbshipit-source-id: d1ff8966fa10ed0387ef36863f3d2959d8157917
6715bbc to
c4545a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35363043 |
…acebookincubator#1347) Summary: Pull Request resolved: facebookincubator#1347 SimpleVector uses a string-ly typed map to store metadata. This seems to be used primarily for storing min/max stats as well as the bias for BiasVectors. This is inefficient because we end up de/serializing back and forth from strings, and doesn't work for all types (e.g. opaque types). This causes issues in VectorMaker as it tries to initialize stats when creating vectors, so we can't create vectors of Opaque types. Since SimpleVector is templated on the underlying type, I add a SimpleVectorStats object, also templated on this type, and pass this to the vector's constructor instead of the map of strings. This way min/max don't need to be serialized/deserialized, and it works for any type. Reviewed By: laithsakka Differential Revision: D35363043 fbshipit-source-id: 853c979184aef8e420154f73ba5738c98cfc5334
c4545a4 to
8dae417
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35363043 |
Arty-Maly
pushed a commit
to Arty-Maly/velox
that referenced
this pull request
May 13, 2022
…acebookincubator#1347) Summary: Pull Request resolved: facebookincubator#1347 SimpleVector uses a string-ly typed map to store metadata. This seems to be used primarily for storing min/max stats as well as the bias for BiasVectors. This is inefficient because we end up de/serializing back and forth from strings, and doesn't work for all types (e.g. opaque types). This causes issues in VectorMaker as it tries to initialize stats when creating vectors, so we can't create vectors of Opaque types. Since SimpleVector is templated on the underlying type, I add a SimpleVectorStats object, also templated on this type, and pass this to the vector's constructor instead of the map of strings. This way min/max don't need to be serialized/deserialized, and it works for any type. Reviewed By: laithsakka Differential Revision: D35363043 fbshipit-source-id: 674cb6d8c2ac4d47a94c9ac9a2138fae4d618c86
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
…acebookincubator#1347) Summary: Pull Request resolved: facebookincubator#1347 SimpleVector uses a string-ly typed map to store metadata. This seems to be used primarily for storing min/max stats as well as the bias for BiasVectors. This is inefficient because we end up de/serializing back and forth from strings, and doesn't work for all types (e.g. opaque types). This causes issues in VectorMaker as it tries to initialize stats when creating vectors, so we can't create vectors of Opaque types. Since SimpleVector is templated on the underlying type, I add a SimpleVectorStats object, also templated on this type, and pass this to the vector's constructor instead of the map of strings. This way min/max don't need to be serialized/deserialized, and it works for any type. Reviewed By: laithsakka Differential Revision: D35363043 fbshipit-source-id: 674cb6d8c2ac4d47a94c9ac9a2138fae4d618c86
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SimpleVector uses a string-ly typed map to store metadata. This seems to be used primarily for storing min/max stats as well as the bias for BiasVectors.
This is inefficient because we end up de/serializing back and forth from strings, and doesn't work for all types (e.g. opaque types). This causes issues in VectorMaker as it tries to initialize stats when creating vectors, so we can't create vectors of Opaque types.
Since SimpleVector is templated on the underlying type, I add a SimpleVectorStats object, also templated on this type, and pass this to the vector's constructor instead of the map of strings. This way min/max don't need to be serialized/deserialized, and it works for any type.
Differential Revision: D35363043