Remove min/max from SimpleVector #1239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D34980442 |
Summary: Pull Request resolved: facebookincubator#1239 Today SimpleVector may receive the min/max values as part of its metadata which means they need to be serialized/deserialized to strings. This seems inefficient, and it doesn't work for types like opaque which can't necessarily be converted to strings a straight forward way. Moreover, it doesn't look like these values are used anywhere outside of tests, so I'm opting to just remove them. If we need them, passing them as std::optional<T> seems like a better way. I'm also changing BiasVector to take the bias directly, instead of doing the same serialization/deserialization. Can we get rid of metadata entirely? Or use a properly typed class instead of a mapping from string:string? Differential Revision: D34980442 fbshipit-source-id: ec7488d4adf27ad7d206f3c5cdb2d6aa865d3de1
14f00f7 to
016de0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34980442 |
|
Having these min/max values will be potentially useful in operators like sort and window functions. Is serializing/deserializing the two values an expensive option? How much can we gain in terms of perf and size on wire? |
|
Found some use cases that were using these, took another approach in #1347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Today SimpleVector may receive the min/max values as part of its metadata which means
they need to be serialized/deserialized to strings.
This seems inefficient, and it doesn't work for types like opaque which can't necessarily
be converted to strings a straight forward way.
Moreover, it doesn't look like these values are used anywhere outside of tests, so I'm
opting to just remove them. If we need them, passing them as std::optional seems
like a better way.
I'm also changing BiasVector to take the bias directly, instead of doing the same
serialization/deserialization.
Can we get rid of metadata entirely? Or use a properly typed class instead of a mapping from string:string?
Differential Revision: D34980442